tox: tip-pylint fails with pylint >= 2.11.1

Bug #1944414 reported by Paride Legovini
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-init
Fix Released
Low
Paride Legovini

Bug Description

As usual we periodically need to:
 - Fix the issue with the newer linters
 - Update the pinned deps in tox.ini

Reproducer:
  - tox -e tip-pylint

Log excerpt:

************* Module cloudinit.subp
cloudinit/subp.py:238: [W1514(unspecified-encoding), subp] Using open without explicitly specifying an encoding
************* Module cloudinit.url_helper
cloudinit/url_helper.py:488: [W1514(unspecified-encoding), OauthUrlHelper.read_skew_file] Using open without explicitly specifying an encoding
cloudinit/url_helper.py:500: [W1514(unspecified-encoding), OauthUrlHelper.update_skew_file] Using open without explicitly specifying an encoding
************* Module cloudinit.analyze.dump
cloudinit/analyze/dump.py:174: [W1514(unspecified-encoding), main] Using open without explicitly specifying an encoding
************* Module cloudinit.analyze.__main__
cloudinit/analyze/__main__.py:218: [W1514(unspecified-encoding), configure_io] Using open without explicitly specifying an encoding
cloudinit/analyze/__main__.py:227: [W1514(unspecified-encoding), configure_io] Using open without explicitly specifying an encoding
************* Module cloudinit.util
cloudinit/util.py:369: [W1514(unspecified-encoding), multi_log] Using open without explicitly specifying an encoding
cloudinit/util.py:1162: [W1514(unspecified-encoding), close_stdin] Using open without explicitly specifying an encoding
cloudinit/util.py:1975: [W1514(unspecified-encoding), write_file] Using open without explicitly specifying an encoding
************* Module cloudinit.cmd.cloud_id
cloudinit/cmd/cloud_id.py:56: [W1514(unspecified-encoding), handle_args] Using open without explicitly specifying an encoding
************* Module cloudinit.cmd.devel.make_mime
cloudinit/cmd/devel/make_mime.py:24: [W1514(unspecified-encoding), file_content_type] Using open without explicitly specifying an encoding
************* Module cloudinit.cmd.main
cloudinit/cmd/main.py:226: [W1514(unspecified-encoding), purge_cache_on_python_version_change] Using open without explicitly specifying an encoding
************* Module cloudinit.cmd.devel.render
cloudinit/cmd/devel/render.py:70: [W1514(unspecified-encoding), handle_args] Using open without explicitly specifying an encoding
************* Module cloudinit.reporting.handlers
cloudinit/reporting/handlers.py:165: [W1514(unspecified-encoding), HyperVKvpReportingHandler._truncate_guest_pool_file] Using open without explicitly specifying an encoding
************* Module cloudinit.net.eni
cloudinit/net/eni.py:179: [W1514(unspecified-encoding), _parse_deb_config_data] Using open without explicitly specifying an encoding
cloudinit/net/eni.py:190: [W1514(unspecified-encoding), _parse_deb_config_data] Using open without explicitly specifying an encoding
cloudinit/net/eni.py:281: [W1514(unspecified-encoding), parse_deb_config] Using open without explicitly specifying an encoding
************* Module cloudinit.net.tests.test_dhcp
cloudinit/net/tests/test_dhcp.py:409: [W1514(unspecified-encoding), TestDHCPDiscoveryClean.test_dhcp_discovery_run_in_sandbox] Using open without explicitly specifying an encoding
cloudinit/net/tests/test_dhcp.py:455: [W1514(unspecified-encoding), TestDHCPDiscoveryClean.test_dhcp_discovery_outside_sandbox] Using open without explicitly specifying an encoding
************* Module cloudinit.tests.helpers
cloudinit/tests/helpers.py:472: [W1514(unspecified-encoding), readResource] Using open without explicitly specifying an encoding
************* Module cloudinit.tests.test_features
cloudinit/tests/test_features.py:31: [W1514(unspecified-encoding), create_override] Using open without explicitly specifying an encoding
************* Module cloudinit.sources.DataSourceNoCloud
cloudinit/sources/DataSourceNoCloud.py:250: [E1135(unsupported-membership-test), _quick_read_instance_id] Value 'md' doesn't support membership test
cloudinit/sources/DataSourceNoCloud.py:251: [E1136(unsubscriptable-object), _quick_read_instance_id] Value 'md' is unsubscriptable
************* Module cloudinit.sources.DataSourceOVF
cloudinit/sources/DataSourceOVF.py:755: [W1514(unspecified-encoding), setup_marker_files] Using open without explicitly specifying an encoding
************* Module cloudinit.sources.DataSourceCloudStack
cloudinit/sources/DataSourceCloudStack.py:253: [W1514(unspecified-encoding), get_vr_address] Using open without explicitly specifying an encoding
************* Module cloudinit.sources.DataSourceVMware
cloudinit/sources/DataSourceVMware.py:270: [W1514(unspecified-encoding), DataSourceVMware.get_instance_id] Using open without explicitly specifying an encoding
************* Module cloudinit.sources.helpers.azure
cloudinit/sources/helpers/azure.py:262: [W1514(unspecified-encoding), get_last_log_byte_pushed_to_kvp_index] Using open without explicitly specifying an encoding
cloudinit/sources/helpers/azure.py:509: [W1514(unspecified-encoding), OpenSSLManager.generate_certificate] Using open without explicitly specifying an encoding
************* Module cloudinit.sources.helpers.vmware.imc.config_passwd
cloudinit/sources/helpers/vmware/imc/config_passwd.py:35: [W1514(unspecified-encoding), PasswordConfigurator.configure] Using open without explicitly specifying an encoding
cloudinit/sources/helpers/vmware/imc/config_passwd.py:40: [W1514(unspecified-encoding), PasswordConfigurator.configure] Using open without explicitly specifying an encoding
************* Module cloudinit.sources.helpers.vmware.imc.guestcust_util
cloudinit/sources/helpers/vmware/imc/guestcust_util.py:76: [W1514(unspecified-encoding), get_nics_to_enable] Using open without explicitly specifying an encoding
************* Module cloudinit.sources.DataSourceAzure
cloudinit/sources/DataSourceAzure.py:2081: [W1514(unspecified-encoding), _check_freebsd_cdrom] Using open without explicitly specifying an encoding
************* Module cloudinit.config.cc_refresh_rmc_and_interface
cloudinit/config/cc_refresh_rmc_and_interface.py:132: [W1514(unspecified-encoding), disable_ipv6] Using open without explicitly specifying an encoding
************* Module cloudinit.config.cc_power_state_change
cloudinit/config/cc_power_state_change.py:139: [W1514(unspecified-encoding), handle] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_reporting_hyperv
tests/unittests/test_reporting_hyperv.py:244: [W1514(unspecified-encoding), TextKvpReporter.test_push_log_to_kvp_exception_handling] Using open without explicitly specifying an encoding
tests/unittests/test_reporting_hyperv.py:267: [W1514(unspecified-encoding), TextKvpReporter.test_push_log_to_kvp] Using open without explicitly specifying an encoding
tests/unittests/test_reporting_hyperv.py:272: [W1514(unspecified-encoding), TextKvpReporter.test_push_log_to_kvp] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_atomic_helper
tests/unittests/test_atomic_helper.py:39: [W1514(unspecified-encoding), TestAtomicHelper.test_write_json] Using open without explicitly specifying an encoding
tests/unittests/test_atomic_helper.py:49: [W1514(unspecified-encoding), TestAtomicHelper.check_file] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_render_cloudcfg
tests/unittests/test_render_cloudcfg.py:28: [W1514(unspecified-encoding), TestRenderCloudCfg.test_variant_sets_distro_in_cloud_cfg] Using open without explicitly specifying an encoding
tests/unittests/test_render_cloudcfg.py:39: [W1514(unspecified-encoding), TestRenderCloudCfg.test_variant_sets_default_user_in_cloud_cfg] Using open without explicitly specifying an encoding
tests/unittests/test_render_cloudcfg.py:57: [W1514(unspecified-encoding), TestRenderCloudCfg.test_variant_sets_network_renderer_priority_in_cloud_cfg] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_util
tests/unittests/test_util.py:85: [W1514(unspecified-encoding), TestWriteFile.test_basic_usage] Using open without explicitly specifying an encoding
tests/unittests/test_util.py:144: [W1514(unspecified-encoding), TestWriteFile.test_preserve_mode_with_existing] Using open without explicitly specifying an encoding
tests/unittests/test_util.py:166: [W1514(unspecified-encoding), TestWriteFile.test_custom_omode] Using open without explicitly specifying an encoding
tests/unittests/test_util.py:173: [W1514(unspecified-encoding), TestWriteFile.test_restorecon_if_possible_is_called] Using open without explicitly specifying an encoding
tests/unittests/test_util.py:537: [W1514(unspecified-encoding), TestMultiLog._createConsole] Using open without explicitly specifying an encoding
tests/unittests/test_util.py:563: [W1514(unspecified-encoding), TestMultiLog.test_logs_go_to_console_by_default] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_net_freebsd
tests/unittests/test_net_freebsd.py:45: [W1514(unspecified-encoding), TestFreeBSDRoundTrip._render_and_read] Using open without explicitly specifying an encoding
tests/unittests/test_net_freebsd.py:47: [W1514(unspecified-encoding), TestFreeBSDRoundTrip._render_and_read] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_vmware.test_custom_script
tests/unittests/test_vmware/test_custom_script.py:65: [W1514(unspecified-encoding), TestVmwareCustomScript.test_prepare_custom_script] Using open without explicitly specifying an encoding
tests/unittests/test_vmware/test_custom_script.py:103: [W1514(unspecified-encoding), TestVmwareCustomScript.test_execute_post_cust] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_ds_identify
tests/unittests/test_ds_identify.py:164: [W1514(unspecified-encoding), DsIdentifyBase.call] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_net
tests/unittests/test_net.py:2756: [W1514(unspecified-encoding), _setup_test] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:2848: [W1514(unspecified-encoding), TestGenerateFallbackConfig.test_device_driver] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:2861: [W1514(unspecified-encoding), TestGenerateFallbackConfig.test_device_driver] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:2912: [W1514(unspecified-encoding), TestGenerateFallbackConfig.test_device_driver_blacklist] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:2925: [W1514(unspecified-encoding), TestGenerateFallbackConfig.test_device_driver_blacklist] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:3089: [W1514(unspecified-encoding), TestRhelSysConfigRendering.test_default_generation] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:3196: [W1514(unspecified-encoding), TestRhelSysConfigRendering.test_openstack_rendering_samples] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:3468: [W1514(unspecified-encoding), TestRhelSysConfigRendering.test_check_ifcfg_rh] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:3769: [W1514(unspecified-encoding), TestOpenSuseSysConfigRendering.test_default_generation] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:3874: [W1514(unspecified-encoding), TestOpenSuseSysConfigRendering.test_openstack_rendering_samples] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:4054: [W1514(unspecified-encoding), TestEniNetRendering.test_default_generation] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:4135: [W1514(unspecified-encoding), TestNetplanNetRendering.test_default_generation] Using open without explicitly specifying an encoding
tests/unittests/test_net.py:5098: [W1514(unspecified-encoding), TestNetworkdNetRendering.test_networkd_default_generation] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_handler.test_handler_etc_hosts
tests/unittests/test_handler/test_handler_etc_hosts.py:36: [W1514(unspecified-encoding), TestHostsFile.test_write_etc_hosts_suse_localhost] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_handler.test_handler_mounts
tests/unittests/test_handler/test_handler_mounts.py:23: [W1514(unspecified-encoding), TestSanitizeDevname._touch] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:310: [W1514(unspecified-encoding), TestFstabHandling.test_no_fstab] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:321: [W1514(unspecified-encoding), TestFstabHandling.test_swap_integrity] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:336: [W1514(unspecified-encoding), TestFstabHandling.test_fstab_no_swap_device] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:341: [W1514(unspecified-encoding), TestFstabHandling.test_fstab_no_swap_device] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:353: [W1514(unspecified-encoding), TestFstabHandling.test_fstab_same_swap_device_already_configured] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:358: [W1514(unspecified-encoding), TestFstabHandling.test_fstab_same_swap_device_already_configured] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:374: [W1514(unspecified-encoding), TestFstabHandling.test_fstab_alternate_swap_device_already_configured] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:379: [W1514(unspecified-encoding), TestFstabHandling.test_fstab_alternate_swap_device_already_configured] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:396: [W1514(unspecified-encoding), TestFstabHandling.test_no_change_fstab_sets_needs_mount_all] Using open without explicitly specifying an encoding
tests/unittests/test_handler/test_handler_mounts.py:398: [W1514(unspecified-encoding), TestFstabHandling.test_no_change_fstab_sets_needs_mount_all] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_handler.test_schema
tests/unittests/test_handler/test_schema.py:520: [W1514(unspecified-encoding), CloudTestsIntegrationTest.test_all_integration_test_cloud_config_schema] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_datasource.test_exoscale
tests/unittests/test_datasource/test_exoscale.py:74: [W1514(unspecified-encoding), TestDatasourceExoscale.test_activate_removes_set_passwords_semaphore] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_datasource.test_altcloud
tests/unittests/test_datasource/test_altcloud.py:37: [W1514(unspecified-encoding), _write_user_data_files] Using open without explicitly specifying an encoding
tests/unittests/test_datasource/test_altcloud.py:42: [W1514(unspecified-encoding), _write_user_data_files] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_datasource.test_configdrive
tests/unittests/test_datasource/test_configdrive.py:715: [W1514(unspecified-encoding), TestConvertNetworkData.test_conversion_with_route] Using open without explicitly specifying an encoding
tests/unittests/test_datasource/test_configdrive.py:737: [W1514(unspecified-encoding), TestConvertNetworkData.test_bond_conversion] Using open without explicitly specifying an encoding
tests/unittests/test_datasource/test_configdrive.py:771: [W1514(unspecified-encoding), TestConvertNetworkData.test_vlan] Using open without explicitly specifying an encoding
************* Module tests.unittests.test_datasource.test_smartos
tests/unittests/test_datasource/test_smartos.py:523: [W1514(unspecified-encoding), TestSmartOSDataSource.test_scripts_shebanged] Using open without explicitly specifying an encoding
tests/unittests/test_datasource/test_smartos.py:550: [W1514(unspecified-encoding), TestSmartOSDataSource.test_scripts_shebang_not_added] Using open without explicitly specifying an encoding
tests/unittests/test_datasource/test_smartos.py:563: [W1514(unspecified-encoding), TestSmartOSDataSource.test_userdata_removed] Using open without explicitly specifying an encoding
************* Module tests.integration_tests.util
tests/integration_tests/util.py:97: [W1514(unspecified-encoding), get_test_rsa_keypair] Using open without explicitly specifying an encoding
tests/integration_tests/util.py:99: [W1514(unspecified-encoding), get_test_rsa_keypair] Using open without explicitly specifying an encoding

Paride Legovini (paride)
Changed in cloud-init:
assignee: nobody → Paride Legovini (paride)
status: New → Triaged
Revision history for this message
James Falcon (falcojr) wrote :

I'm fine with adding an ignore for this particular warning for a while.

Changed in cloud-init:
importance: Undecided → Low
Revision history for this message
Paride Legovini (paride) wrote :

Hi! I prepared a branch which fixes the warnings:

https://github.com/canonical/cloud-init/pull/1029

I was also tempted to ignore the warning, but then decided not to do so, see this commit message:

https://github.com/canonical/cloud-init/pull/1029/commits/0a0d0d79cbf54b55885201f6245c50f4d5bf9fa2

The PR is open but as a WIP with an open question.

James Falcon (falcojr)
Changed in cloud-init:
status: Triaged → Fix Committed
Revision history for this message
James Falcon (falcojr) wrote : Fixed in cloud-init version 21.4.

This bug is believed to be fixed in cloud-init in version 21.4. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Changed in cloud-init:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers