Chef module fails to complete when chef_license is specified

[Alex]

When the chef_license attribute is specified, the cloud-init run fails to complete as the attribute is interpreted as a path. The suggested fix for this is to move the attribute from CHEF_RB_TPL_PATH_KEYS to CHEF_RB_TPL_DEFAULTS

CHEF_RB_TPL_DEFAULTS = {
    # These are ruby symbols...
    'ssl_verify_mode': ':verify_none',
    'log_level': ':info',
    # These are not symbols...
    'log_location': '/var/log/chef/client.log',
    'validation_key': CHEF_VALIDATION_PEM_PATH,
    'validation_cert': None,
    'client_key': '/etc/chef/client.pem',
    'json_attribs': CHEF_FB_PATH,
    'file_cache_path': '/var/cache/chef',
    'file_backup_path': '/var/backups/chef',
    'pid_file': '/var/run/chef/client.pid',
    'show_time': True,
    'encrypted_data_bag_secret': None,
}
CHEF_RB_TPL_BOOL_KEYS = frozenset(['show_time'])
CHEF_RB_TPL_PATH_KEYS = frozenset([
    'log_location',
    'validation_key',
    'client_key',
    'file_cache_path',
    'json_attribs',
    'pid_file',
    'encrypted_data_bag_secret',
    'chef_license',
])

[Alex (scahartner)]

Proposed fix : https://code.launchpad.net/~scahartner/cloud-init/+git/cloud-init/+ref/Fix-1912424/+register-merge

[Mina Galić (minagalic)]

please note that patches have moved to github pull requests: https://github.com/canonical/cloud-init/pulls/

see also https://cloudinit.readthedocs.io/en/latest/topics/hacking.html#submitting-your-first-pull-request

[Alex (scahartner)]

I am a little lost here. I thought I did that already. Would you be able to take a look at: https://code.launchpad.net/~scahartner/cloud-init/+git/cloud-init/+ref/Fix-1912424 and let me know how I can get this submitted correctly.

[Dan Watkins (oddbloke)]

Hey Alex, so I think what's happened is you've conflated a couple of parts of our process. If you haven't previously signed the Canonical CLA with your Launchpad ID (which AFAICT is true for you: you haven't), then you don't need to touch Launchpad at all for code submissions any longer. The steps in https://cloudinit.readthedocs.io/en/latest/topics/hacking.html#submitting-your-first-pull-request should guide you through submitting a GitHub pull request with your change.

Does that make sense? If not, feel free to reply here or reach out in #cloud-init on Freenode.

(I've proposed a doc change which will hopefully help folks avoid this confusion in future, if you'd like to take a look: https://github.com/canonical/cloud-init/pull/789)

Thanks!

[Wes Deviers (wdeviers)]

Is there any way I can help with this?

[Dan Watkins (oddbloke)]

Alex, are you still planning on submitting this via GitHub? Or could someone else pick this up to push forward?

[Ben Hughes (bmhughes)]

Ran into this recently and have put a PR in: https://github.com/canonical/cloud-init/pull/868. Pretty sure i've done everything I need to procedure wise.

[James Falcon (falcojr)]

This bug is believed to be fixed in cloud-init in version 21.2. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/3831