cc_seed_random: unexpectedly appends cloud's random_seed to specified seed data

Bug #1911227 reported by Dan Watkins on 2021-01-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-init
Medium
Dan Watkins

Bug Description

The test_seed_random_data test specifies this user-data:

#cloud-config
random_seed:
  data: 'MYUb34023nD:LFDK10913jk;dfnk:Df'
  encoding: raw
  file: /root/seed

and asserts that that is the exact content of /root/seed. If we're using a datasource which sets random_seed in its metadata (i.e. Azure and OpenStack, at least), this test fails: cc_seed_random will _append_ the cloud's random_seed to the given data before writing it out.

To be clear, the bug here is that this is unexpected: we do not document this behaviour. I can't think of a compelling case for not behaving in this way: more entropy is good, and we have write_files if users really do want to write out exact content to a path.

The TestSeedRandomData.test_seed_random_data integration test assumes the "exact writing" behaviour, so will also need to be updated.

Dan Watkins (oddbloke) on 2021-01-12
Changed in cloud-init:
status: New → Triaged
importance: Undecided → Medium
summary: cc_seed_random: unexpectedly appends cloud's random_seed to specified
- seed
+ seed data
Dan Watkins (oddbloke) on 2021-01-12
description: updated
Dan Watkins (oddbloke) wrote :

I've just opened a PR for this: https://github.com/canonical/cloud-init/pull/771

Changed in cloud-init:
status: Triaged → In Progress
Dan Watkins (oddbloke) wrote :

The PR has landed, as this is a doc and test change, we don't need to wait for a release to mark this Fix Released.

Changed in cloud-init:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers