Swap file creation broken due to incorrect format specifiers

[Jeremy Norris]

Swap file creation currently fails with the following error:
cc_mounts.py[WARNING]: failed to setup swap: %d format: a number is required, not str

This appears to be fallout from changes from this commit:
https://github.com/canonical/cloud-init/commit/6603706
https://github.com/canonical/cloud-init/pull/70

It appears several '%d' format specifiers are being incorrectly paired with a string type variable instead of number type variable.

[Chad Smith (chad.smith)]

An upstream commit landed for this fix at
https://github.com/canonical/cloud-init/commit/9d7b35ce23aaf8741dd49b16e359c96591be3c76

[Jeremy Norris (jeremy.norris)]

Hi Chad,

Thanks for rapidly fixing this. Do you know if this will be pulled in before next week's 20.04 LTS release?

Thanks,
Jeremy

[Chad Smith (chad.smith)]

Jeremy we are queuing an upload for this as we speak.
the hope is it will be pulled in.

[Jeremy Norris (jeremy.norris)]

Hi Chad,

Excellent, thanks!

-Jeremy

[Launchpad Janitor (janitor)]

This bug was fixed in the package cloud-init - 20.1-10-g71af48df-0ubuntu5

---------------
cloud-init (20.1-10-g71af48df-0ubuntu5) focal; urgency=medium

  * cherry-pick 0c5c7367: test_mounts: expand happy path test for both
    happy paths

 -- Daniel Watkins <email address hidden> Thu, 16 Apr 2020 11:23:08 -0400

[Jeremy Norris (jeremy.norris)]

I hope that 9d7b35ce was also picked up, as that was the actual fix for this issue?
0c5c7367 appears simply to be a follow-up change to the new unit test that was included in 9d7b35ce.

[Dan Watkins (oddbloke)]

On Thu, Apr 16, 2020 at 07:31:02PM -0000, Jeremy Norris wrote:
> I hope that 9d7b35ce was also picked up, as that was the actual fix for this issue?
> 0c5c7367 appears simply to be a follow-up change to the new unit test that was included in 9d7b35ce.

Yep, the messaging is a little confusing. The test in 0c5c7367 had an
issue that only appeared on the Launchpad build infrastructure, so the
ubuntu4 package failed to build. There was a follow-up upload of the
fix for the unit test, and that's what actually caused the package to
end up in focal (because the tests could pass), and that's what we're
getting notified about.

(As an aside, I think I should have generated my upload artifacts
differently so that both changelog entries were posted here. I'll dig
into that to remind myself for next time.)

Thanks for the diligence!

[Jeremy Norris (jeremy.norris)]

Hi Dan,

Excellent, I figured it was something simple like that, just wanted to make sure. :)

Thanks!
Jeremy

[Chad Smith (chad.smith)]

This bug is believed to be fixed in cloud-init in version 20.2. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/3652