RuntimeError: dictionary keys changed during iteration

[Noah Meyerhans]

Forwarded from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954276

This appears to be a python 3.8 incompatibility.

| 2020-03-19 14:31:48,840 - util.py[DEBUG]: Running module disk_setup (<module 'cloudinit.config.cc_disk_setup' from '/usr/lib/python3/dist-packages/cloudinit/config/cc_disk_setup.py'>) failed
| Traceback (most recent call last):
| File "/usr/lib/python3/dist-packages/cloudinit/stages.py", line 848, in _run_modules
| ran, _r = cc.run(run_name, mod.handle, func_args,
| File "/usr/lib/python3/dist-packages/cloudinit/cloud.py", line 54, in run
| return self._runners.run(name, functor, args, freq, clear_on_fail)
| File "/usr/lib/python3/dist-packages/cloudinit/helpers.py", line 185, in run
| results = functor(*args)
| File "/usr/lib/python3/dist-packages/cloudinit/config/cc_disk_setup.py", line 129, in handle
| update_disk_setup_devices(disk_setup, cloud.device_name_to_device)
| File "/usr/lib/python3/dist-packages/cloudinit/config/cc_disk_setup.py", line 166, in update_disk_setup_devices
| for origname in disk_setup.keys():
| RuntimeError: dictionary keys changed during iteration

I've attached a small patch that implements a minimal fix for this issue.

[Chad Smith (chad.smith)]

Upstream fix committed for this bug at https://github.com/canonical/cloud-init/commit/04771d75a8670f07ae4c75b5892e3b795e9d1a07

[Chad Smith (chad.smith)]

This bug is believed to be fixed in cloud-init in version 20.2. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/3630