Headers no longer passed through read_file_or_url

Bug #1854084 reported by Thomas Stringer on 2019-11-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-init
Undecided
Chad Smith

Bug Description

This commit (https://git.launchpad.net/cloud-init/commit/?id=4bc399e0cd0b7e9177f948aecd49f6b8323ff30b) has a diff that includes the removal of passing headers through to readurl from read_file_or_url: https://github.com/canonical/cloud-init/commit/4bc399e0cd0b7e9177f948aecd49f6b8323ff30b#diff-a779470bb47168497ada0a33f7990b01L104

With this commit, the headers parameter is virtually useless (besides with raising the exception). This has caused us to no longer pass through headers (https://github.com/canonical/cloud-init/commit/4bc399e0cd0b7e9177f948aecd49f6b8323ff30b#diff-a779470bb47168497ada0a33f7990b01L104) when we make a request using read_file_or_url (https://github.com/canonical/cloud-init/blob/master/cloudinit/sources/helpers/azure.py#L186).

Chad Smith (chad.smith) on 2019-11-26
Changed in cloud-init:
status: New → Confirmed
assignee: nobody → Chad Smith (chad.smith)
status: Confirmed → In Progress
Chad Smith (chad.smith) wrote :

Upstream fix committed for this bug: https://github.com/canonical/cloud-init/commit/f69d33a723b805fec3ee70c3a6127c8cadcb02d8.

This fix is also queue for SRU into Xenial, Bionic Disco and Eaon in cloud-init v. 19.3.41.
If it is still a problem for you. Please re-open this bug.

Changed in cloud-init:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers