cloud-init

Exoscale datasource overwrites *all* cloud_config_modules

Bug #1841454 reported by Chris Glass
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-init
Fix Released
Undecided
Unassigned

Bug Description

While testing the Exoscale datasource for its inclusion in a SRU, it was discovered that a cloud_config_module didn't work.

Passing user data such as: https://gist.github.com/chrisglass/fb0cf860be8cf01f456dfff8e162e004 results in the "runcmd" stanza not to be executed.

(feel free to get in touch should you like to play with an instance displaying the problem on Eoan)

Hypothesis:

The merge of the datasource's extra_config field (https://git.launchpad.net/cloud-init/tree/cloudinit/sources/DataSourceExoscale.py#n124) is erroneous: instead of *overwriting* the cloud_config_modules entry from the cloud.cfg file/user data, the cloud_config_modules should be *merged*.
An additional difficulty being that we insert a two-elements list (["set-passwords", "always"]) and it needs to be merge with a list containing just "set-passwords".

Related branches

~chad.smith/cloud-init:ubuntu/xenial
Server Team CI bot: Needs Fixing (continuous-integration)
cloud-init Commiters: Pending requested
Diff: 557 lines (+279/-81)
7 files modified
cloudinit/net/cmdline.py (+95/-32)
cloudinit/sources/DataSourceExoscale.py (+17/-9)
cloudinit/sources/DataSourceOracle.py (+20/-16)
cloudinit/sources/tests/test_oracle.py (+36/-3)
debian/changelog (+9/-0)
tests/unittests/test_datasource/test_exoscale.py (+16/-8)
tests/unittests/test_net.py (+86/-13)
~chad.smith/cloud-init:ubuntu/bionic
Server Team CI bot: Needs Fixing (continuous-integration)
cloud-init Commiters: Pending requested
Diff: 557 lines (+279/-81)
7 files modified
cloudinit/net/cmdline.py (+95/-32)
cloudinit/sources/DataSourceExoscale.py (+17/-9)
cloudinit/sources/DataSourceOracle.py (+20/-16)
cloudinit/sources/tests/test_oracle.py (+36/-3)
debian/changelog (+9/-0)
tests/unittests/test_datasource/test_exoscale.py (+16/-8)
tests/unittests/test_net.py (+86/-13)
~chad.smith/cloud-init:ubuntu/disco
Server Team CI bot: Approve (continuous-integration)
Ryan Harper: Approve
Diff: 557 lines (+279/-81)
7 files modified
cloudinit/net/cmdline.py (+95/-32)
cloudinit/sources/DataSourceExoscale.py (+17/-9)
cloudinit/sources/DataSourceOracle.py (+20/-16)
cloudinit/sources/tests/test_oracle.py (+36/-3)
debian/changelog (+9/-0)
tests/unittests/test_datasource/test_exoscale.py (+16/-8)
tests/unittests/test_net.py (+86/-13)
~chad.smith/cloud-init:bug/1841454-exoscale-config-modules
Server Team CI bot: Approve (continuous-integration)
Ryan Harper: Approve
Chris Glass (community): Approve
Diff: 116 lines (+33/-17)
2 files modified
cloudinit/sources/DataSourceExoscale.py (+17/-9)
tests/unittests/test_datasource/test_exoscale.py (+16/-8)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

This bug is fixed with commit d1b02221 to cloud-init on branch master.
To view that commit see the following URL:
https://git.launchpad.net/cloud-init/commit/?id=d1b02221

Changed in cloud-init:
status: New → Fix Committed
Revision history for this message
Chad Smith (chad.smith) wrote : Fixed in cloud-init version 19.2-23.

This bug is believed to be fixed in cloud-init in version 19.2-23. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Changed in cloud-init:
status: Fix Committed → Fix Released
Revision history for this message
James Falcon (falcojr) wrote :

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/3436

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.