Xenial, Bionic, Cosmic revert ubuntu-advantage-tools config module changes from tip
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cloud-init |
Fix Released
|
Undecided
|
Chad Smith | ||
cloud-init (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Cosmic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
== Begin SRU Template ==
[Impact]
Ubuntu-
Changes in cloud-init 19.1 support only the new ubuntu-
To avoid breaking the cc_ubuntu_advantage cloud-config module, we need to revert changes in cloud-init tip to avoid tracebacks for customers in Xenial, Bionic and Cosmic using ubuntu-advantage: declarating in their cloud-config.
Once ubuntu-
[Test Case]
# Use old ubuntu-advantage cloud-config syntax to enable livepatch on a kvm instance to enable livepatch
Note: there are a number of expected failures
* Xenial: Bug: #1830154 snap not in $PATH
* Cosmic: livepatch is not supported on Cosmic
* Disco: Bug: #1829788 KeyError traceback
[Test Case]
cat > pre-disco-ua.yaml <<EOF
#cloud-config
hostname: sru-test
ubuntu-advantage:
commands:
00: ubuntu-advantage enable-livepatch <REDACTED_
EOF
cat > disco-ua.yaml <<EOF
#cloud-config
hostname: sru-test
ubuntu_advantage:
token: <REDACTED_
enable: [livepatch]
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/
apt-get update -q;
apt-get install -qy cloud-init;
EOF
#!/bin/bash
set -e
# Perform individual bug tests using lxd for speed where possible
for series in xenial bionic cosmic disco; do
echo "=== BEGIN $series";
if [ $series = disco ]; then
multipass launch daily:$series -n test-$series --cloud-init disco-ua.yaml;
else
multipass launch daily:$series -n test-$series --cloud-init pre-disco-ua.yaml;
fi
multipass exec test-$series -- cloud-init status --wait;
if [ $series = bionic ]; then
echo "Disabling livepatch on $series";
multipass exec test-$series sudo ubuntu-advantage disable-livepatch;
multipass exec test-$series sudo snap remove canonical-
elif [ $series = disco ]; then
echo "Detaching ubuntu-advantage on $series";
multipass exec test-$series sudo ubuntu-advantage detach;
elif [ $series = cosmic -o $series = xenial ]; then
multipass exec test-$series sudo snap remove canonical-
fi
echo "Rebooting into clean system";
multipass exec test-$series -- sudo cloud-init clean --logs --reboot;
if [ $series = disco ]; then
echo "Expect error [$series] per known LP: #1829788 KeyError traceback from ubuntu-
elif [ $series = bionic ]; then
echo "Ensure no errors [$series] from cloud-init status";
elif [ $series = cosmic ]; then
echo "Expect [$series] error that livepatch does not support $series";
else
echo "Expect error [$series] about snap not in PATH LP: #1830154";
fi
sleep 10;
while ! multipass exec test-$series -- pwd; do
sleep 5
done
multipass exec test-$series -- cloud-init status --wait --long;
multipass exec test-$series -- grep Trace /var/log/
echo "Checking ubuntu-advantage status";
multipass exec test-$series -- ubuntu-advantage status;
echo "=== END $series";
done
[Regression Potential]
Changeset only affects systems deployed using the ubuntu-advantage module. In Xenial, Bionic and Cosmic. Existing behavior is retained because of a full revert of the upstream patch.
This ubuntu-advantage config module is not widely used and the underlying ubuntu-
[Other Info]
Upstream commit at
https:/
== End SRU Template ==
=== Original description ===
Xenial Bionic and Cosmic are currently running earlier versions of ubuntu-
ubuntu-
Until ubuntu-
Related branches
- Ryan Harper: Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 4639 lines (+2418/-613)49 files modifiedChangeLog (+117/-0)
cloudinit/cmd/main.py (+5/-4)
cloudinit/config/cc_apt_configure.py (+1/-1)
cloudinit/config/cc_mounts.py (+11/-0)
cloudinit/config/cc_ubuntu_advantage.py (+116/-109)
cloudinit/config/cc_ubuntu_drivers.py (+112/-0)
cloudinit/config/tests/test_ubuntu_advantage.py (+191/-156)
cloudinit/config/tests/test_ubuntu_drivers.py (+174/-0)
cloudinit/net/eni.py (+11/-5)
cloudinit/net/network_state.py (+33/-8)
cloudinit/net/sysconfig.py (+29/-11)
cloudinit/net/tests/test_init.py (+1/-1)
cloudinit/reporting/handlers.py (+57/-60)
cloudinit/sources/DataSourceAzure.py (+179/-95)
cloudinit/sources/DataSourceCloudStack.py (+1/-1)
cloudinit/sources/DataSourceConfigDrive.py (+2/-5)
cloudinit/sources/DataSourceEc2.py (+7/-3)
cloudinit/sources/DataSourceNoCloud.py (+3/-1)
cloudinit/sources/helpers/azure.py (+42/-3)
cloudinit/util.py (+17/-13)
cloudinit/version.py (+1/-1)
config/cloud.cfg.tmpl (+3/-0)
debian/changelog (+48/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu-advantage-revert-tip.patch (+735/-0)
doc/rtd/topics/datasources/azure.rst (+35/-22)
doc/rtd/topics/datasources/nocloud.rst (+1/-1)
doc/rtd/topics/modules.rst (+1/-0)
packages/redhat/cloud-init.spec.in (+3/-1)
packages/suse/cloud-init.spec.in (+3/-1)
setup.py (+2/-1)
tests/cloud_tests/releases.yaml (+16/-0)
tests/cloud_tests/testcases/modules/apt_pipelining_disable.yaml (+1/-2)
tests/cloud_tests/testcases/modules/apt_pipelining_os.py (+3/-3)
tests/cloud_tests/testcases/modules/apt_pipelining_os.yaml (+4/-5)
tests/data/azure/non_unicode_random_string (+1/-0)
tests/unittests/test_datasource/test_azure.py (+32/-5)
tests/unittests/test_datasource/test_azure_helper.py (+7/-2)
tests/unittests/test_datasource/test_nocloud.py (+42/-0)
tests/unittests/test_distros/test_netconfig.py (+2/-0)
tests/unittests/test_ds_identify.py (+17/-0)
tests/unittests/test_handler/test_handler_mounts.py (+29/-1)
tests/unittests/test_handler/test_schema.py (+1/-0)
tests/unittests/test_net.py (+251/-18)
tests/unittests/test_reporting_hyperv.py (+49/-55)
tools/build-on-freebsd (+4/-5)
tools/ds-identify (+4/-3)
tools/read-version (+5/-2)
tox.ini (+8/-9)
- Ryan Harper: Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 2193 lines (+1247/-204)38 files modifiedChangeLog (+117/-0)
cloudinit/config/cc_apt_configure.py (+1/-1)
cloudinit/config/cc_mounts.py (+11/-0)
cloudinit/net/sysconfig.py (+4/-2)
cloudinit/net/tests/test_init.py (+1/-1)
cloudinit/reporting/handlers.py (+57/-60)
cloudinit/sources/DataSourceAzure.py (+11/-6)
cloudinit/sources/DataSourceCloudStack.py (+1/-1)
cloudinit/sources/DataSourceConfigDrive.py (+2/-5)
cloudinit/sources/DataSourceEc2.py (+1/-1)
cloudinit/sources/DataSourceNoCloud.py (+3/-1)
cloudinit/sources/DataSourceScaleway.py (+1/-2)
cloudinit/sources/__init__.py (+3/-3)
cloudinit/sources/helpers/azure.py (+11/-3)
cloudinit/sources/tests/test_init.py (+0/-15)
cloudinit/util.py (+2/-13)
cloudinit/version.py (+1/-1)
debian/changelog (+48/-2)
debian/patches/azure-apply-network-config-false.patch (+1/-1)
debian/patches/azure-use-walinux-agent.patch (+1/-1)
debian/patches/series (+1/-0)
debian/patches/ubuntu-advantage-revert-tip.patch (+735/-0)
doc/rtd/topics/datasources/nocloud.rst (+1/-1)
packages/redhat/cloud-init.spec.in (+3/-1)
packages/suse/cloud-init.spec.in (+3/-1)
setup.py (+2/-1)
tests/cloud_tests/releases.yaml (+16/-0)
tests/unittests/test_datasource/test_azure.py (+10/-3)
tests/unittests/test_datasource/test_azure_helper.py (+7/-2)
tests/unittests/test_datasource/test_nocloud.py (+42/-0)
tests/unittests/test_datasource/test_scaleway.py (+0/-7)
tests/unittests/test_ds_identify.py (+17/-0)
tests/unittests/test_handler/test_handler_mounts.py (+29/-1)
tests/unittests/test_net.py (+42/-3)
tests/unittests/test_reporting_hyperv.py (+49/-55)
tools/build-on-freebsd (+4/-5)
tools/ds-identify (+4/-3)
tools/read-version (+5/-2)
summary: |
- xenial, Bionic, Cosmic revert ubuntu-advantage-tools config module + Xenial, Bionic, Cosmic revert ubuntu-advantage-tools config module changes from tip |
Changed in cloud-init: | |
assignee: | nobody → Chad Smith (chad.smith) |
status: | New → In Progress |
description: | updated |
description: | updated |
Changed in cloud-init (Ubuntu): | |
status: | New → Invalid |
Changed in cloud-init: | |
status: | In Progress → Fix Released |
Hello Chad, or anyone else affected,
Accepted cloud-init into cosmic-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ cloud-init/ 19.1-1- gbaa47854- 0ubuntu1~ 18.10.1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification- needed- cosmic to verification- done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed- cosmic. In either case, without details of your testing we will not be able to proceed.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance for helping!
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.