suse (packages/suse/cloud-init.spec.in) spec does not build

[Scott Moser]

I've done some work with 'tools/run-container' [1] and
'./tools/read-dependencies' [2] so now we are reasonably close to
being able to build and test opensuse in c-i.

However, at the moement the spec file has some issues:

a.) jinja syntax error (fix http://paste.ubuntu.com/p/CXmmsVgK9b/)
b.) unpacks into wrong directory (fix http://paste.ubuntu.com/p/q28xc5X3gT/)
c.) TODO file is gone. (fix http://paste.ubuntu.com/p/ZDnHsGhhfc/)
d.) no need to remove tests, no longer installed (fix http://paste.ubuntu.com/p/TmKFqgz3rZ/)

After those things are done, then we fail like:
   + /usr/lib/rpm/brp-suse
   error: Installed (but unpackaged) file(s) found:
      /etc/NetworkManager/dispatcher.d/hook-network-manager
      /etc/dhcp/dhclient-exit-hooks.d/hook-dhclient
      /lib/udev/rules.d/66-azure-ephemeral.rules
      /usr/lib/cloud-init/ds-identify
      /usr/lib/systemd/system-generators/cloud-init-generator
      /usr/lib/systemd/system/cloud-config.service
      /usr/lib/systemd/system/cloud-config.target
      /usr/lib/systemd/system/cloud-final.service
      /usr/lib/systemd/system/cloud-init-local.service
      /usr/lib/systemd/system/cloud-init.service
      /usr/lib/systemd/system/cloud-init.target

At the end of this fix, we should be able to do:
  ./tools/run-container -vv \
     --artifacts=rpms/ --unittest --package --source-package opensuse/42.3

and run have done on opensuse 42.3:
 a.) run unit-tests with packaged versions of dependencies.
 b.) build source package
 c.) build binary package.

https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/346747
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/345627

[Scott Moser (smoser)]

https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+ref/fix/1772961-suse-spec-fixes
has a branch of those changes.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/3187