DataSourceOpenNebula's get_mask() and get_network() return empty string
Bug #1736750 reported by
Akihiko Ota
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cloud-init |
Fix Released
|
Medium
|
Unassigned |
Bug Description
In DataSourceOpenN
The problem occures when OpenNebula creats instances with Virtual Network resources which CONTEXT Attributes NETWORK_ADDRESS and/or NETWORK_MASK are not defined.
It seems that get_ip() also has the same bug.
I attached a patch for this problem.
Related branches
~chad.smith/cloud-init:ubuntu/devel
- Server Team CI bot: Approve (continuous-integration)
- Scott Moser: Pending requested
-
Diff: 1537 lines (+767/-173)23 files modified.gitignore (+1/-0)
cloudinit/config/cc_resizefs.py (+11/-1)
cloudinit/config/cc_rsyslog.py (+5/-5)
cloudinit/net/__init__.py (+2/-2)
cloudinit/net/dhcp.py (+42/-1)
cloudinit/net/network_state.py (+12/-0)
cloudinit/sources/DataSourceAzure.py (+129/-9)
cloudinit/sources/DataSourceEc2.py (+7/-16)
cloudinit/sources/DataSourceOpenNebula.py (+59/-53)
cloudinit/sources/__init__.py (+1/-1)
cloudinit/sources/helpers/azure.py (+14/-8)
cloudinit/temp_utils.py (+8/-3)
cloudinit/tests/test_util.py (+46/-0)
cloudinit/url_helper.py (+20/-9)
cloudinit/util.py (+17/-6)
debian/changelog (+13/-0)
doc/rtd/topics/network-config-format-v1.rst (+1/-1)
tests/unittests/test_datasource/test_azure.py (+151/-6)
tests/unittests/test_datasource/test_ec2.py (+1/-1)
tests/unittests/test_datasource/test_opennebula.py (+177/-46)
tests/unittests/test_handler/test_handler_resizefs.py (+21/-1)
tests/unittests/test_net.py (+15/-3)
tools/read-version (+14/-1)
~sw37th/cloud-init:fix_for_opennebula
- Scott Moser: Approve
- Server Team CI bot: Needs Fixing (continuous-integration)
-
Diff: 501 lines (+241/-104)4 files modifiedcloudinit/net/__init__.py (+2/-2)
cloudinit/sources/DataSourceOpenNebula.py (+59/-53)
tests/unittests/test_datasource/test_opennebula.py (+177/-46)
tests/unittests/test_net.py (+3/-3)
description: | updated |
Changed in cloud-init: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in cloud-init: | |
status: | Confirmed → Fix Committed |
To post a comment you must log in.
Akihiko,
Thanks for filing a bug and even submitting a fix!
We use git and launchpad to do merge proposals. This is described at cloudinit. readthedocs. io/en/latest/ topics/ hacking. html
http://
Please note that in order to accept your fix you'll have to sign the Contributors Agreement. That process is also described in the hacking link above.
Please feel free to reach out if you have any questions.
Thanks!