ds-identify does not recognize Fujitsu Cloud Service S5 as OVF
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cloud-init |
Fix Released
|
Medium
|
Scott Moser |
Bug Description
*******
# A new feature in cloud-init identified possible datasources for #
# this system as: #
# ['Ec2', 'None'] #
# However, the datasource used was: OVF #
# #
# In the future, cloud-init will only attempt to use datasources that #
# are identified or specifically configured. #
# For more information see #
# https:/
# #
# If you are seeing this message, please file a bug against #
# cloud-init at #
# https:/
# Make sure to include the cloud provider your instance is #
# running on.
1. Cloud provider is Fujitsu Cloud Service S5, after upgrading from Ubuntu 14 to 16.04.2 LTS
2. 0.7.9-113-
3. None
4.
Related branches
- Server Team CI bot: Needs Fixing (continuous-integration)
- Scott Moser: Pending requested
-
Diff: 10355 lines (+5108/-1157)144 files modified.gitignore (+1/-0)
.pylintrc (+2/-2)
ChangeLog (+85/-0)
HACKING.rst (+8/-0)
cloudinit/analyze/__main__.py (+3/-1)
cloudinit/analyze/dump.py (+1/-7)
cloudinit/cmd/clean.py (+103/-0)
cloudinit/cmd/main.py (+37/-7)
cloudinit/cmd/status.py (+160/-0)
cloudinit/cmd/tests/__init__.py (+0/-0)
cloudinit/cmd/tests/test_clean.py (+176/-0)
cloudinit/cmd/tests/test_status.py (+368/-0)
cloudinit/config/cc_apt_configure.py (+3/-2)
cloudinit/config/cc_disk_setup.py (+5/-3)
cloudinit/config/cc_landscape.py (+4/-4)
cloudinit/config/cc_ntp.py (+5/-5)
cloudinit/config/cc_power_state_change.py (+1/-0)
cloudinit/config/cc_resizefs.py (+11/-1)
cloudinit/config/cc_rh_subscription.py (+2/-3)
cloudinit/config/cc_rsyslog.py (+5/-5)
cloudinit/config/cc_seed_random.py (+2/-1)
cloudinit/config/cc_snap_config.py (+5/-2)
cloudinit/distros/__init__.py (+18/-13)
cloudinit/distros/freebsd.py (+3/-8)
cloudinit/ec2_utils.py (+30/-9)
cloudinit/net/__init__.py (+2/-2)
cloudinit/net/cmdline.py (+5/-4)
cloudinit/net/dhcp.py (+42/-1)
cloudinit/net/network_state.py (+17/-3)
cloudinit/sources/DataSourceAliYun.py (+1/-0)
cloudinit/sources/DataSourceAltCloud.py (+5/-2)
cloudinit/sources/DataSourceAzure.py (+150/-21)
cloudinit/sources/DataSourceBigstep.py (+4/-1)
cloudinit/sources/DataSourceCloudSigma.py (+4/-1)
cloudinit/sources/DataSourceCloudStack.py (+4/-1)
cloudinit/sources/DataSourceConfigDrive.py (+6/-3)
cloudinit/sources/DataSourceDigitalOcean.py (+4/-1)
cloudinit/sources/DataSourceEc2.py (+41/-24)
cloudinit/sources/DataSourceGCE.py (+99/-40)
cloudinit/sources/DataSourceMAAS.py (+44/-15)
cloudinit/sources/DataSourceNoCloud.py (+4/-1)
cloudinit/sources/DataSourceNone.py (+4/-1)
cloudinit/sources/DataSourceOVF.py (+92/-38)
cloudinit/sources/DataSourceOpenNebula.py (+66/-56)
cloudinit/sources/DataSourceOpenStack.py (+4/-1)
cloudinit/sources/DataSourceScaleway.py (+3/-1)
cloudinit/sources/DataSourceSmartOS.py (+4/-1)
cloudinit/sources/__init__.py (+117/-14)
cloudinit/sources/helpers/azure.py (+16/-9)
cloudinit/sources/helpers/vmware/imc/config.py (+4/-0)
cloudinit/sources/helpers/vmware/imc/config_custom_script.py (+153/-0)
cloudinit/sources/helpers/vmware/imc/config_nic.py (+1/-1)
cloudinit/sources/tests/__init__.py (+0/-0)
cloudinit/sources/tests/test_init.py (+202/-0)
cloudinit/temp_utils.py (+8/-3)
cloudinit/tests/helpers.py (+35/-7)
cloudinit/tests/test_util.py (+46/-0)
cloudinit/url_helper.py (+20/-9)
cloudinit/util.py (+129/-64)
cloudinit/version.py (+1/-1)
debian/changelog (+55/-3)
dev/null (+0/-172)
doc/rtd/topics/boot.rst (+10/-3)
doc/rtd/topics/capabilities.rst (+153/-7)
doc/rtd/topics/debugging.rst (+1/-0)
doc/rtd/topics/modules.rst (+2/-0)
doc/rtd/topics/network-config-format-v1.rst (+1/-1)
doc/rtd/topics/tests.rst (+32/-6)
integration-requirements.txt (+20/-0)
setup.py (+24/-1)
systemd/cloud-init-local.service.tmpl (+0/-6)
tests/cloud_tests/__init__.py (+6/-0)
tests/cloud_tests/bddeb.py (+4/-4)
tests/cloud_tests/collect.py (+28/-16)
tests/cloud_tests/config.py (+3/-1)
tests/cloud_tests/platforms.yaml (+6/-5)
tests/cloud_tests/platforms/__init__.py (+20/-2)
tests/cloud_tests/platforms/ec2/image.py (+99/-0)
tests/cloud_tests/platforms/ec2/instance.py (+132/-0)
tests/cloud_tests/platforms/ec2/platform.py (+258/-0)
tests/cloud_tests/platforms/ec2/snapshot.py (+66/-0)
tests/cloud_tests/platforms/images.py (+2/-1)
tests/cloud_tests/platforms/instances.py (+69/-1)
tests/cloud_tests/platforms/lxd/image.py (+5/-6)
tests/cloud_tests/platforms/lxd/instance.py (+22/-27)
tests/cloud_tests/platforms/lxd/platform.py (+7/-7)
tests/cloud_tests/platforms/lxd/snapshot.py (+2/-2)
tests/cloud_tests/platforms/nocloudkvm/image.py (+5/-16)
tests/cloud_tests/platforms/nocloudkvm/instance.py (+72/-59)
tests/cloud_tests/platforms/nocloudkvm/platform.py (+11/-9)
tests/cloud_tests/platforms/nocloudkvm/snapshot.py (+2/-22)
tests/cloud_tests/platforms/platforms.py (+96/-0)
tests/cloud_tests/platforms/snapshots.py (+0/-0)
tests/cloud_tests/releases.yaml (+10/-22)
tests/cloud_tests/setup_image.py (+0/-18)
tests/cloud_tests/testcases.yaml (+21/-6)
tests/cloud_tests/testcases/base.py (+6/-3)
tests/cloud_tests/testcases/modules/apt_configure_sources_list.py (+5/-0)
tests/cloud_tests/testcases/modules/apt_configure_sources_list.yaml (+6/-0)
tests/cloud_tests/testcases/modules/ntp_pools.yaml (+1/-1)
tests/cloud_tests/testcases/modules/ntp_servers.yaml (+1/-1)
tests/cloud_tests/testcases/modules/set_hostname_fqdn.py (+1/-1)
tests/cloud_tests/util.py (+16/-3)
tests/cloud_tests/verify.py (+1/-1)
tests/unittests/test_cli.py (+99/-6)
tests/unittests/test_cs_util.py (+1/-0)
tests/unittests/test_datasource/test_aliyun.py (+17/-1)
tests/unittests/test_datasource/test_altcloud.py (+13/-9)
tests/unittests/test_datasource/test_azure.py (+204/-40)
tests/unittests/test_datasource/test_cloudsigma.py (+9/-4)
tests/unittests/test_datasource/test_cloudstack.py (+13/-6)
tests/unittests/test_datasource/test_configdrive.py (+25/-37)
tests/unittests/test_datasource/test_digitalocean.py (+13/-7)
tests/unittests/test_datasource/test_ec2.py (+5/-3)
tests/unittests/test_datasource/test_gce.py (+174/-22)
tests/unittests/test_datasource/test_maas.py (+46/-7)
tests/unittests/test_datasource/test_nocloud.py (+6/-8)
tests/unittests/test_datasource/test_opennebula.py (+182/-53)
tests/unittests/test_datasource/test_openstack.py (+8/-4)
tests/unittests/test_datasource/test_ovf.py (+107/-4)
tests/unittests/test_datasource/test_scaleway.py (+9/-4)
tests/unittests/test_datasource/test_smartos.py (+2/-1)
tests/unittests/test_distros/test_create_users.py (+5/-2)
tests/unittests/test_distros/test_netconfig.py (+46/-6)
tests/unittests/test_ds_identify.py (+130/-3)
tests/unittests/test_handler/test_handler_lxd.py (+0/-3)
tests/unittests/test_handler/test_handler_power_state.py (+0/-3)
tests/unittests/test_handler/test_handler_resizefs.py (+21/-1)
tests/unittests/test_handler/test_handler_yum_add_repo.py (+2/-8)
tests/unittests/test_handler/test_handler_zypper_add_repo.py (+1/-6)
tests/unittests/test_net.py (+15/-3)
tests/unittests/test_reporting.py (+1/-1)
tests/unittests/test_runs/test_merge_run.py (+1/-0)
tests/unittests/test_runs/test_simple_run.py (+2/-1)
tests/unittests/test_templating.py (+1/-1)
tests/unittests/test_util.py (+64/-3)
tests/unittests/test_vmware/__init__.py (+0/-0)
tests/unittests/test_vmware/test_custom_script.py (+99/-0)
tests/unittests/test_vmware_config_file.py (+9/-1)
tools/ds-identify (+81/-35)
tools/make-mime.py (+1/-1)
tools/mock-meta.py (+21/-24)
tools/read-version (+14/-1)
tox.ini (+5/-6)
- Server Team CI bot: Approve (continuous-integration)
- Scott Moser: Pending requested
-
Diff: 10348 lines (+5108/-1154)144 files modified.gitignore (+1/-0)
.pylintrc (+2/-2)
ChangeLog (+85/-0)
HACKING.rst (+8/-0)
cloudinit/analyze/__main__.py (+3/-1)
cloudinit/analyze/dump.py (+1/-7)
cloudinit/cmd/clean.py (+103/-0)
cloudinit/cmd/main.py (+37/-7)
cloudinit/cmd/status.py (+160/-0)
cloudinit/cmd/tests/__init__.py (+0/-0)
cloudinit/cmd/tests/test_clean.py (+176/-0)
cloudinit/cmd/tests/test_status.py (+368/-0)
cloudinit/config/cc_apt_configure.py (+3/-2)
cloudinit/config/cc_disk_setup.py (+5/-3)
cloudinit/config/cc_landscape.py (+4/-4)
cloudinit/config/cc_ntp.py (+5/-5)
cloudinit/config/cc_power_state_change.py (+1/-0)
cloudinit/config/cc_resizefs.py (+11/-1)
cloudinit/config/cc_rh_subscription.py (+2/-3)
cloudinit/config/cc_rsyslog.py (+5/-5)
cloudinit/config/cc_seed_random.py (+2/-1)
cloudinit/config/cc_snap_config.py (+5/-2)
cloudinit/distros/__init__.py (+18/-13)
cloudinit/distros/freebsd.py (+3/-8)
cloudinit/ec2_utils.py (+30/-9)
cloudinit/net/__init__.py (+2/-2)
cloudinit/net/cmdline.py (+5/-4)
cloudinit/net/dhcp.py (+42/-1)
cloudinit/net/network_state.py (+17/-3)
cloudinit/sources/DataSourceAliYun.py (+1/-0)
cloudinit/sources/DataSourceAltCloud.py (+5/-2)
cloudinit/sources/DataSourceAzure.py (+150/-21)
cloudinit/sources/DataSourceBigstep.py (+4/-1)
cloudinit/sources/DataSourceCloudSigma.py (+4/-1)
cloudinit/sources/DataSourceCloudStack.py (+4/-1)
cloudinit/sources/DataSourceConfigDrive.py (+6/-3)
cloudinit/sources/DataSourceDigitalOcean.py (+4/-1)
cloudinit/sources/DataSourceEc2.py (+41/-24)
cloudinit/sources/DataSourceGCE.py (+99/-40)
cloudinit/sources/DataSourceMAAS.py (+44/-15)
cloudinit/sources/DataSourceNoCloud.py (+4/-1)
cloudinit/sources/DataSourceNone.py (+4/-1)
cloudinit/sources/DataSourceOVF.py (+92/-38)
cloudinit/sources/DataSourceOpenNebula.py (+66/-56)
cloudinit/sources/DataSourceOpenStack.py (+4/-1)
cloudinit/sources/DataSourceScaleway.py (+3/-1)
cloudinit/sources/DataSourceSmartOS.py (+4/-1)
cloudinit/sources/__init__.py (+117/-14)
cloudinit/sources/helpers/azure.py (+16/-9)
cloudinit/sources/helpers/vmware/imc/config.py (+4/-0)
cloudinit/sources/helpers/vmware/imc/config_custom_script.py (+153/-0)
cloudinit/sources/helpers/vmware/imc/config_nic.py (+1/-1)
cloudinit/sources/tests/__init__.py (+0/-0)
cloudinit/sources/tests/test_init.py (+202/-0)
cloudinit/temp_utils.py (+8/-3)
cloudinit/tests/helpers.py (+35/-7)
cloudinit/tests/test_util.py (+46/-0)
cloudinit/url_helper.py (+20/-9)
cloudinit/util.py (+129/-64)
cloudinit/version.py (+1/-1)
debian/changelog (+55/-0)
dev/null (+0/-172)
doc/rtd/topics/boot.rst (+10/-3)
doc/rtd/topics/capabilities.rst (+153/-7)
doc/rtd/topics/debugging.rst (+1/-0)
doc/rtd/topics/modules.rst (+2/-0)
doc/rtd/topics/network-config-format-v1.rst (+1/-1)
doc/rtd/topics/tests.rst (+32/-6)
integration-requirements.txt (+20/-0)
setup.py (+24/-1)
systemd/cloud-init-local.service.tmpl (+0/-6)
tests/cloud_tests/__init__.py (+6/-0)
tests/cloud_tests/bddeb.py (+4/-4)
tests/cloud_tests/collect.py (+28/-16)
tests/cloud_tests/config.py (+3/-1)
tests/cloud_tests/platforms.yaml (+6/-5)
tests/cloud_tests/platforms/__init__.py (+20/-2)
tests/cloud_tests/platforms/ec2/image.py (+99/-0)
tests/cloud_tests/platforms/ec2/instance.py (+132/-0)
tests/cloud_tests/platforms/ec2/platform.py (+258/-0)
tests/cloud_tests/platforms/ec2/snapshot.py (+66/-0)
tests/cloud_tests/platforms/images.py (+2/-1)
tests/cloud_tests/platforms/instances.py (+69/-1)
tests/cloud_tests/platforms/lxd/image.py (+5/-6)
tests/cloud_tests/platforms/lxd/instance.py (+22/-27)
tests/cloud_tests/platforms/lxd/platform.py (+7/-7)
tests/cloud_tests/platforms/lxd/snapshot.py (+2/-2)
tests/cloud_tests/platforms/nocloudkvm/image.py (+5/-16)
tests/cloud_tests/platforms/nocloudkvm/instance.py (+72/-59)
tests/cloud_tests/platforms/nocloudkvm/platform.py (+11/-9)
tests/cloud_tests/platforms/nocloudkvm/snapshot.py (+2/-22)
tests/cloud_tests/platforms/platforms.py (+96/-0)
tests/cloud_tests/platforms/snapshots.py (+0/-0)
tests/cloud_tests/releases.yaml (+10/-22)
tests/cloud_tests/setup_image.py (+0/-18)
tests/cloud_tests/testcases.yaml (+21/-6)
tests/cloud_tests/testcases/base.py (+6/-3)
tests/cloud_tests/testcases/modules/apt_configure_sources_list.py (+5/-0)
tests/cloud_tests/testcases/modules/apt_configure_sources_list.yaml (+6/-0)
tests/cloud_tests/testcases/modules/ntp_pools.yaml (+1/-1)
tests/cloud_tests/testcases/modules/ntp_servers.yaml (+1/-1)
tests/cloud_tests/testcases/modules/set_hostname_fqdn.py (+1/-1)
tests/cloud_tests/util.py (+16/-3)
tests/cloud_tests/verify.py (+1/-1)
tests/unittests/test_cli.py (+99/-6)
tests/unittests/test_cs_util.py (+1/-0)
tests/unittests/test_datasource/test_aliyun.py (+17/-1)
tests/unittests/test_datasource/test_altcloud.py (+13/-9)
tests/unittests/test_datasource/test_azure.py (+204/-40)
tests/unittests/test_datasource/test_cloudsigma.py (+9/-4)
tests/unittests/test_datasource/test_cloudstack.py (+13/-6)
tests/unittests/test_datasource/test_configdrive.py (+25/-37)
tests/unittests/test_datasource/test_digitalocean.py (+13/-7)
tests/unittests/test_datasource/test_ec2.py (+5/-3)
tests/unittests/test_datasource/test_gce.py (+174/-22)
tests/unittests/test_datasource/test_maas.py (+46/-7)
tests/unittests/test_datasource/test_nocloud.py (+6/-8)
tests/unittests/test_datasource/test_opennebula.py (+182/-53)
tests/unittests/test_datasource/test_openstack.py (+8/-4)
tests/unittests/test_datasource/test_ovf.py (+107/-4)
tests/unittests/test_datasource/test_scaleway.py (+9/-4)
tests/unittests/test_datasource/test_smartos.py (+2/-1)
tests/unittests/test_distros/test_create_users.py (+5/-2)
tests/unittests/test_distros/test_netconfig.py (+46/-6)
tests/unittests/test_ds_identify.py (+130/-3)
tests/unittests/test_handler/test_handler_lxd.py (+0/-3)
tests/unittests/test_handler/test_handler_power_state.py (+0/-3)
tests/unittests/test_handler/test_handler_resizefs.py (+21/-1)
tests/unittests/test_handler/test_handler_yum_add_repo.py (+2/-8)
tests/unittests/test_handler/test_handler_zypper_add_repo.py (+1/-6)
tests/unittests/test_net.py (+15/-3)
tests/unittests/test_reporting.py (+1/-1)
tests/unittests/test_runs/test_merge_run.py (+1/-0)
tests/unittests/test_runs/test_simple_run.py (+2/-1)
tests/unittests/test_templating.py (+1/-1)
tests/unittests/test_util.py (+64/-3)
tests/unittests/test_vmware/__init__.py (+0/-0)
tests/unittests/test_vmware/test_custom_script.py (+99/-0)
tests/unittests/test_vmware_config_file.py (+9/-1)
tools/ds-identify (+81/-35)
tools/make-mime.py (+1/-1)
tools/mock-meta.py (+21/-24)
tools/read-version (+14/-1)
tox.ini (+5/-6)
- Server Team CI bot: Approve (continuous-integration)
- Scott Moser: Pending requested
-
Diff: 666 lines (+278/-63)19 files modifiedHACKING.rst (+8/-0)
cloudinit/cmd/status.py (+5/-2)
cloudinit/cmd/tests/test_status.py (+18/-3)
cloudinit/config/cc_power_state_change.py (+1/-0)
cloudinit/config/cc_rh_subscription.py (+2/-3)
cloudinit/distros/freebsd.py (+3/-8)
cloudinit/util.py (+4/-0)
debian/changelog (+11/-0)
doc/rtd/topics/boot.rst (+10/-3)
doc/rtd/topics/capabilities.rst (+153/-7)
doc/rtd/topics/debugging.rst (+1/-0)
doc/rtd/topics/modules.rst (+2/-0)
tests/cloud_tests/collect.py (+7/-0)
tests/cloud_tests/platforms/lxd/instance.py (+19/-24)
tests/cloud_tests/testcases.yaml (+21/-6)
tests/cloud_tests/testcases/base.py (+4/-2)
tests/cloud_tests/verify.py (+1/-1)
tests/unittests/test_ds_identify.py (+5/-3)
tools/ds-identify (+3/-1)
- Server Team CI bot: Approve (continuous-integration)
- Ryan Harper: Approve
-
Diff: 43 lines (+8/-4)2 files modifiedtests/unittests/test_ds_identify.py (+5/-3)
tools/ds-identify (+3/-1)
summary: |
- cloud-init datasource used was OVF + ds-identify does not recognize Fujitsu Cloud Service S5 as OVF |
tags: | added: dsid-block-xenial |
Changed in cloud-init: | |
status: | Confirmed → Fix Committed |
assignee: | nobody → Scott Moser (smoser) |
Hi,
It looks like this cloud uses ovf datasource, and that they did so by attaching a disk to with an filesystem label OVFENV.
I think that there might be two bugs in the 'dscheck_OVF' in ds-identify that we could fix.
a.) has_cdrom seems to have returned false. I was relying on udev to have created a /dev/cdrom link to /dev/sr0. its possible that has not happened at the point the generator was run.
b.) we should consider a filesystem label OVFENV as indicating there is an ovf environment file on a cdrom (especially when it is on a sr0 device as is the case here).