Switch Azure detection to use chassis_asset_tag

[Paul Meyer]

=== Begin SRU Template ===
[Impact]
Azure identifies itself to guests by setting a well known value in the chassis asset field of dmi data. This is done both in Azure public cloud and in Azure Stack (the on-premise variant of Azure).

By checking for this value cloud-init can more quickly identify whether or not it is running on Azure.

[Test Case]
 - Launch an instance, enable proposed, upgrade.
 - Clean instance and re-boot
   $ rm -Rf /var/lib/cloud /var/log/cloud-init*
   $ rm -f /etc/cloud/cloud.cfg.d/91_walinuxagent.cfg # bug 1700769
   $ reboot

 - ssh back in look around
   - confirm 'WARN' does not appear in /var/log/cloud-init*
   - look in /run/cloud-init/ds-identify.log. It should say:
      Found single datasource: Azure

 - reboot, ssh back in and verify all still good.

[Regression Potential]
Instances running in Azure or Azure Stack that did *not* have this value
would not be identified as Azure. We have been told by representatives
from Microsoft that that will not be the case.

[Other Info]
Upstream commit at
  https://git.launchpad.net/cloud-init/commit/?id=5fb49bac

=== End SRU Template ===

I've got confirmation that the chassis_asset_tag DMI value is a hard-coded identifier for the Azure platform (both Azure and Azure Stack (the on-premise variant of Azure)).

$ cat /sys/class/dmi/id/chassis_asset_tag
7783-7084-3265-9085-8269-3286-77

The detection logic in both ds-identify and Azure ds should be updated to use this value.

[Scott Moser (smoser)]

Paul,
Hi and thanks.
Are you saying that that constant will be in chassis asset in all instances?

If so, thats great.

[Paul Meyer (paul-meyer)]

Yes, that's correct. All Azure and Azurestack instances will have this chassis asset tag.

[Steve Langasek (vorlon)]

Hello Paul, or anyone else affected,

Accepted cloud-init into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.9-153-g16a7302f-0ubuntu1~17.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty.If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Steve Langasek (vorlon)]

Hello Paul, or anyone else affected,

Accepted cloud-init into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.9-153-g16a7302f-0ubuntu1~16.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-yakkety to verification-done-yakkety.If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-yakkety. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Steve Langasek (vorlon)]

Hello Paul, or anyone else affected,

Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.9-153-g16a7302f-0ubuntu1~16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial.If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Paul Meyer (paul-meyer)]

Successfully verified 0.7.9-153-g16a7302f-0ubuntu1~16.04.2 on Xenial on Azure using the Test Case in the SRU.

[Paul Meyer (paul-meyer)]

Successfully verified 0.7.9-153-g16a7302f-0ubuntu1~16.10.2 on Yakkety on Azure using the test case in the SRU template.

[Paul Meyer (paul-meyer)]

Successfully verified 0.7.9-153-g16a7302f-0ubuntu1~17.04.2 on Zesty on Azure using the test case from the SRU template.

[Launchpad Janitor (janitor)]

This bug was fixed in the package cloud-init - 0.7.9-153-g16a7302f-0ubuntu1~16.04.2

---------------
cloud-init (0.7.9-153-g16a7302f-0ubuntu1~16.04.2) xenial-proposed; urgency=medium

  * debian/patches/ds-identify-behavior-xenial.patch: refresh patch.
  * cherry-pick 5fb49bac: azure: identify platform by well known value
    in chassis asset (LP: #1693939)
  * cherry-pick 003c6678: net: remove systemd link file writing from eni
    renderer
  * cherry-pick 1cd4323b: azure: remove accidental duplicate line in
    merge.
  * cherry-pick ebc9ecbc: Azure: Add network-config, Refactor net layer
    to handle duplicate macs. (LP: #1690430)
  * cherry-pick 11121fe4: systemd: make cloud-final.service run before
    apt daily (LP: #1693361)

 -- Scott Moser <email address hidden> Wed, 28 Jun 2017 17:17:18 -0400

[Steve Langasek (vorlon)]

The verification of the Stable Release Update for cloud-init has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package cloud-init - 0.7.9-153-g16a7302f-0ubuntu1~17.04.2

---------------
cloud-init (0.7.9-153-g16a7302f-0ubuntu1~17.04.2) zesty-proposed; urgency=medium

  * cherry-pick 5fb49bac: azure: identify platform by well known value
    in chassis asset (LP: #1693939)
  * cherry-pick 003c6678: net: remove systemd link file writing from eni
    renderer
  * cherry-pick 1cd4323b: azure: remove accidental duplicate line in
    merge.
  * cherry-pick ebc9ecbc: Azure: Add network-config, Refactor net layer
    to handle duplicate macs. (LP: #1690430)
  * cherry-pick 11121fe4: systemd: make cloud-final.service run before
    apt daily (LP: #1693361)

 -- Scott Moser <email address hidden> Wed, 28 Jun 2017 17:20:51 -0400

[Scott Moser (smoser)]

This bug is believed to be fixed in cloud-init in 17.1. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/2911