centos7 unit tests fail due to hard coded mkfs.ext4
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
cloud-init |
Fix Released
|
Medium
|
Unassigned | ||
cloud-init (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Xenial |
Fix Released
|
Medium
|
Unassigned | ||
Yakkety |
Fix Released
|
Medium
|
Unassigned | ||
Zesty |
Fix Released
|
Medium
|
Unassigned |
Bug Description
=== Begin SRU Template ===
[Impact]
Unit tests for cloud-init did not run successfully in a centos environment.
This is really just failure of the unit tests.
The fix was to no longer expect /sbin/mkfs.ext4 but to mock the checking.
[Test Case]
Test of ubuntu package in centos is non-trivial and/or not useful.
The proposed test case is to just run the trunk tests at the
uploaded git commit in a lxc container (the environment that originally
found the issue).
$ lxc launch images:centos/7 c7
$ sleep 10; # let it boot
$ lxc exec c7 -- /bin/sh -xe <<"EOF"
yum install --assumeyes epel-release
yum install --assumeyes pyserial python-argparse python-cheetah python-configobj python-jinja2 python-jsonpatch python-oauthlib python-prettytable python-requests python-six python-pip PyYAML git file e2fsprogs
pip install contextlib2 httpretty mock nose pep8 unittest2
git clone https:/
cd cloud-init
git checkout 16a7302f
nosetests tests/unittests
EOF
[Regression Potential]
No runtime regression potential.
Unit test only changes.
[Other Info]
Upstream commit at
https:/
=== End SRU Template ===
A recent merge that added a mkfs.ext4 tests has a hard coded location for the binary of mkfs.ext4. The result is that on centos 7, which has the command in a different location than Ubuntu, is a failed test:
https:/
Steps to reproduce:
lxc launch images:centos/7 c7
lxc exec c7 bash
yum install --assumeyes epel-release
yum install --assumeyes pyserial python-argparse python-cheetah python-configobj python-jinja2 python-jsonpatch python-oauthlib python-prettytable python-requests python-six python-pip PyYAML git file e2fsprogs
pip install contextlib2 httpretty mock nose pep8 unittest2
git clone https:/
cd cloud-init
nosetests tests/unittests
Related branches
- Scott Moser: Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 17 lines (+3/-1)1 file modifiedtests/unittests/test_handler/test_handler_disk_setup.py (+3/-1)
description: | updated |
description: | updated |
Changed in cloud-init: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
assignee: | nobody → Joshua Powers (powersj) |
status: | Confirmed → Fix Committed |
Changed in cloud-init (Ubuntu): | |
status: | New → Fix Released |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Xenial): | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Zesty): | |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Yakkety): | |
importance: | Undecided → Medium |
Changed in cloud-init (Ubuntu Zesty): | |
status: | New → Confirmed |
Changed in cloud-init (Ubuntu Yakkety): | |
status: | New → Confirmed |
description: | updated |
description: | updated |
Changed in cloud-init: | |
assignee: | Joshua Powers (powersj) → nobody |
Hello Joshua, or anyone else affected,
Accepted cloud-init into zesty-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ cloud-init/ 0.7.9-153- g16a7302f- 0ubuntu1~ 17.04.1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed. In either case, details of your testing will help us make a better decision.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!