Wrong default key 'fdqn' in POST_LIST_ALL / cc_phone_home.py

[Roland Sommer]

==== Begin SRU Template ====
[Impact]
A feature of cloud-init to post its fully qualified domain name
to a web service was broken.

[Test Case]
## Recreate failure

$ cat >user-data <<EOF
#cloud-config
phone_home:
  url: http://requestb.in/1b51ma71
  post: all
  tries: 3
EOF

$ lxc launch ubuntu-daily:xenial x1 "--config=user.user-data=$(cat user-data)"
$ lxc exec x1 -- grep WARN /var/log/cloud-init.log
Sep 13 20:52:09 ubuntu [CLOUDINIT] cc_phone_home.py[WARNING]: Requested key fdqn from 'post' configuration list not available

## Now update container, clean and reboot to show first boot
$ lxc exec x1 -- sh -c '
    p=/etc/apt/sources.list.d/proposed.list
    echo deb http://archive.ubuntu.com/ubuntu xenial-proposed main > "$p" &&
    apt-get update -q && apt-get -qy install cloud-init'
$ lxc exec x1 -- sh -c '
    cd /var/lib/cloud && for d in *; do [ "$d" = "seed" ] || rm -Rf "$d"; done
    rm -Rf /var/log/cloud-init*'

$ lxc exec x1 reboot
$ lxc exec x1 -- grep WARN /var/log/cloud-init.log || echo no warn
no warn

# at this point https://requestb.in/1b51ma71?inspect will show the POST
# and will have 'fqdn' of x1.localdomain.

[Regression Potential]
Low risk of regression. Fix of typo.
==== End SRU Template ====

The cloud-init phone_home default list of keys to post back includes 'fdqn' but it should be 'fqdn'. This is logged in the cloud-init logfiles, because the key 'fdqn' does not exist.

[Scott Moser (smoser)]

Thanks!

[Scott Moser (smoser)]

fixed in 0.7.8.

[Chris J Arges (arges)]

Hello Roland, or anyone else affected,

Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.7-31-g65ace7b-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Scott Moser (smoser)]

I walked through the lxc recreate and fix above, and verified the requestbin had
FORM/POST PARAMETERS

pub_key_dsa: ssh-dss AAAAB3NzaC1kc3MAAACBAODRrFvfTNBcIxb3WW4nJGrzYgsOmva2thRKrHtbwUfcZw2+ZvSAt2lX/++y+T+QM6aAJ6pfF4eU08R0FAym9sLhjbsjtEL0hpNipnpONK4qsjqFMwBXjpPoUgIFatRcVloOYw38idgsp2X05K0yod8lsx04XyadGsXRoBOpkpmbAAAAFQCb7bVvK/x6VkiKC+vjfbS+kA6SgQAAAIEArIKEFmS0XotEzSlDNMzVAMRxmJ2P6++8syRmfxTUYu4YR2unQrVvn7iySSWIIPaHMqK6NowgEqKuTwycRL87aMnh43dFJ1QMtgJOyZ2VfPVfuinl/jZVa+Xmy0tckQ61/2/p9xPslbGFQ0+NxOVjMI3b22dmYFgkibgjIIyIkwcAAACAGFtiU5ZUKKVm3e+scptnnszd+++/jIcHxfTKLPojfdwUQJN5U8joUdeYbQFOsc9ZMb4NYbU9KxFUqJR8s2B1mFFXR32QQNCxmqkNHbaJj/iBA4diIAit/sb+IrYsGzMkZfFYwZ4Sx72/ycLRCKF9Q/brvhEWJHet4XMF+dOVqkA= root@x1

fqdn: x1.localdomain

hostname: x1

[Martin Pitt (pitti)]

Hello Roland, or anyone else affected,

Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.8-1-g3705bb5-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Roland Sommer (rsommer)]

I walked through the test an everything went fine, fqdn got reported as 'fqdn: x1.localdomain'.

[Roland Sommer (rsommer)]

Request data from requestb.in for the test i did:

=== Headers ===
X-Request-Id: d4573b6e-fceb-4186-9fa5-c84cdc4fd67c
Accept: */*
Host: requestb.in
Connection: close
Cf-Ray: 2e32518715322696-FRA
Cf-Visitor: {"scheme":"http"}
Cf-Ipcountry: DE
Accept-Encoding: gzip
Content-Length: 1300
User-Agent: Cloud-Init/0.7.8
Connect-Time: 0
Via: 1.1 vegur
Cf-Connecting-Ip: 213.144.0.78
Total-Route-Time: 0
Content-Type: application/x-www-form-urlencoded

=== Data ===
pub_key_ecdsa: ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBLVOSVogoOb2iqPCrcV4Rq4mI9fZSYwyjn8cto3oNVal1AqMk65zCTojOIXjlQB4O9FdS48NMyC/Be/kIcE7GK4= root@x1
instance_id: x1
pub_key_rsa: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC9bmTd5Rxru0ljThHtbf/zn+fgsMWNB6Q34YATDt6T3BChdZI37DqDuxNa7yU7MlzOxGcZybz+IJGwAsJLtCgWO/3qf5pb/nzHuXP/Rqs8UAiXU967aqwGOIH1WBI6p3TV0a2pvVO5bpFsyozdKquVvUGM7T7o3U2dJBQbtK0qrMArPPkwnmpqp3/DjI/L/FGJQtNeQh9X3ptti5gqQeOsMrZ1BorzwA84uZVpewTllinIistRaRqAmE9qQuLlf6Q6fPxK1DJttg3wjRpNMkTxX2YD/fntWh2ztX11bNQUswoQNggOHdD9M3fD7gEXDeG7QAgPEejVBQuWl4jhvQdj root@x1
fqdn: x1.localdomain
pub_key_dsa: ssh-dss AAAAB3NzaC1kc3MAAACBALsHGkVue4sAlJ0V4kJD7H56pbxICkh766Rq6LSvS3mXgzEYBUi1S5ScIcGQOqoJljIsi6v70hf2hrDxps7lWZFr2LK7ZtPvinOlSpQo3o7Zcm2Eeh8aaTBzA6pHotRixJQ6opx1CifiWsVg26VRgejgQGL/X68q5DU5IQkwQAhPAAAAFQDIxs7AXZ3kzgEW3zE0JsCzfT4mUQAAAIB2ltV5v+6H3nAMrabHMcDPBXBUrjvslJ+Bq2S5jQA8cjQoW8bReq14oCsUjb4pDju3HQrZMjKjcBgu8Xtn446OGY2G4iivE9EGULwpr8cAeIIqvt9YiKHnPEh4jDM0IYxbBnbThcvxB5d73KDtubkNtT8XdHRLCugcNtyuomYrGwAAAIEAsQa4iTiyYjj47TsFknbLye5j1LbMEHC/2Gy+I2UgIOjm7ZOdzZAn5yYd3qe8wLHAyDK9RSRYUogtpb+SnE/+KUVjZOgGH1RRCiDO85zTvwTp65mvJ8hHRY7qlWrcfjc0R6eLcP8MYbPCKQXKh/uiikjP2u2YgHQW0rjoSwjsAuU= root@x1
hostname: x1

[Scott Moser (smoser)]

verified

$ cat >user-data <<EOF
#cloud-config
phone_home:
  url: http://requestb.in/1b51ma71
  post: all
  tries: 3
EOF

$ n=x1
$ lxc delete --force $n
$ lxc launch ubuntu-daily:xenial x1 "--config=user.user-data=$(cat user-data)"
$ lxc exec x1 -- grep WARN /var/log/cloud-init.log </dev/null
Sep 13 20:52:09 ubuntu [CLOUDINIT] cc_phone_home.py[WARNING]: Requested key fdqn from 'post' configuration list not available

## Now update container, clean and reboot to show first boot
$ lxc exec $n -- sh -c '
    p=/etc/apt/sources.list.d/proposed.list
    echo deb http://archive.ubuntu.com/ubuntu xenial-proposed main > "$p" &&
    apt-get update -q && apt-get -qy install cloud-init' </dev/null
$ lxc exec $n -- sh -c '
    cd /var/lib/cloud && for d in *; do [ "$d" = "seed" ] || rm -Rf "$d"; done
    rm -Rf /var/log/cloud-init*' </dev/null

$ lxc exec $n reboot
$ sleep 10
$ lxc exec $n -- grep WARN /var/log/cloud-init.log || echo no warn
no warn
$ lxc exec $n -- dpkg-query --show cloud-init
cloud-init 0.7.8-1-g3705bb5-0ubuntu1~16.04.1

[Launchpad Janitor (janitor)]

This bug was fixed in the package cloud-init - 0.7.8-1-g3705bb5-0ubuntu1~16.04.1

---------------
cloud-init (0.7.8-1-g3705bb5-0ubuntu1~16.04.1) xenial-proposed; urgency=medium

  * New upstream release 0.7.8.
  * New upstream snapshot.
    - systemd: put cloud-init.target After multi-user.target (LP: #1623868)

cloud-init (0.7.7-31-g65ace7b-0ubuntu1~16.04.2) xenial-proposed; urgency=medium

  * debian/control: add Breaks of older versions of walinuxagent (LP: #1623570)

cloud-init (0.7.7-31-g65ace7b-0ubuntu1~16.04.1) xenial-proposed; urgency=medium

  * debian/control: fix missing dependency on python3-serial,
    and make SmartOS datasource work.
  * debian/cloud-init.templates fix capitalisation in template so
    dpkg-reconfigure works to select OpenStack. (LP: #1575727)
  * d/README.source, d/control, d/new-upstream-snapshot, d/rules: sync
    with yakkety for changes due to move to git.
  * d/rules: change PYVER=python3 to PYVER=3 to adjust to upstream change.
  * debian/rules, debian/cloud-init.install: remove install file
    to ensure expected files are collected into cloud-init deb.
    (LP: #1615745)
  * debian/dirs: remove obsolete / unused file.
  * upstream move from bzr to git.
  * New upstream snapshot.
    - Allow link type of null in network_data.json [Jon Grimm] (LP: #1621968)
    - DataSourceOVF: fix user-data as base64 with python3 (LP: #1619394)
    - remove obsolete .bzrignore
    - systemd: Better support package and upgrade. (LP: #1576692, #1621336)
    - tests: cleanup tempdirs in apt_source tests
    - apt config conversion: treat empty string as not provided. (LP: #1621180)
    - Fix typo in default keys for phone_home [Roland Sommer] (LP: #1607810)
    - salt minion: update default pki directory for newer salt minion.
      (LP: #1609899)
    - bddeb: add --release flag to specify the release in changelog.
    - apt-config: allow both old and new format to be present.
      [Christian Ehrhardt] (LP: #1616831)
    - python2.6: fix dict comprehension usage in _lsb_release. [Joshua Harlow]
    - Add a module that can configure spacewalk. [Joshua Harlow]
    - add install option for openrc [Matthew Thode]
    - Generate a dummy bond name for OpenStack (LP: #1605749)
    - network: fix get_interface_mac for bond slave, read_sys_net for ENOTDIR
    - azure dhclient-hook cleanups
    - Minor cleanups to atomic_helper and add unit tests.
    - Fix Gentoo net config generation [Matthew Thode]
    - distros: fix get_primary_arch method use of os.uname [Andrew Jorgensen]
    - Apt: add new apt configuration format [Christian Ehrhardt]
    - Get Azure endpoint server from DHCP client [Brent Baude]
    - DigitalOcean: use the v1.json endpoint [Ben Howard]
    - MAAS: add vendor-data support (LP: #1612313)
    - Upgrade to a configobj package new enough to work [Joshua Harlow]
    - ConfigDrive: recognize 'tap' as a link type. (LP: #1610784)
    - NoCloud: fix bug providing network-interfaces via meta-data.
      (LP: 1577982)
    - Add distro tags on config modules that should have it [Joshua Harlow]
    - ChangeLog: update changelog for previous commit.
    - add ntp config module [Ryan Harper]
    - SmartOS: more improvement...

[Chris J Arges (arges)]

The verification of the Stable Release Update for cloud-init has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/2702