can't install requirements by Makefile

Bug #1521079 reported by Keisuke Se
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
cloud-init
Won't Fix
Medium
Keisuke Se

Bug Description

`*requirements` target name is wrong, isn't it?.

```
$ make pip-test-requirements
make: Nothing to be done for 'pip-test-requirements'.

$ make pip-test-requirements
Installing cloud-init test dependencies...
pip install -r "pip-test-requirements.txt" -q
Could not open requirements file: [Errno 2] No such file or directory: 'pip-test-requirements.txt'
Makefile:30: recipe for target 'pip-test-requirements' failed
make: *** [pip-test-requirements] Error 1
```

Makefile
```
pip-requirements:
    @echo "Installing cloud-init dependencies..."
    $(PIP_INSTALL) -r "$@.txt" -q

pip-test-requirements:
    @echo "Installing cloud-init test dependencies..."
    $(PIP_INSTALL) -r "$@.txt" -q
```

```
$ ls -l *requirements.txt
-rw-r--r-- 1 vagrant vagrant 948 11月 30 15:12 requirements.txt
-rw-r--r-- 1 vagrant vagrant 71 11月 30 15:12 test-requirements.txt
```

Revision history for this message
Keisuke Se (se-keisuke) wrote :
Changed in cloud-init:
assignee: nobody → Keisuke Se (se-keisuke)
Revision history for this message
Joshua Powers (powersj) wrote :

Thank you for taking the time to report this bug. In an effort to keep
an up-to-date and valid list of bugs to work on, I have reviewed this
report verifying it still requires effort and occurs on a supported
version of Ubuntu.

It looks like you have a patch ready to go. Would you be willing to
submit a merge proposal with that patch? If so take a look at the
hacking document here:

https://cloudinit.readthedocs.io/en/latest/topics/hacking.html

Thanks!

Changed in cloud-init:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Brett Holman (holmanb) wrote :

These targets no longer exist in the makefile, and these days we use tox rather than the Makefile.

Closing

Changed in cloud-init:
status: Confirmed → Won't Fix
Revision history for this message
James Falcon (falcojr) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.