Activity log for bug #1354694

Date Who What changed Old value New value Message
2014-08-09 13:42:43 Colin Walters bug added bug
2014-08-09 13:43:09 Colin Walters attachment added Patch https://bugs.launchpad.net/cloud-init/+bug/1354694/+attachment/4173307/+files/cloud-init-groupadd.patch
2014-08-21 17:50:49 Scott Moser cloud-init: status New Confirmed
2014-08-21 17:50:52 Scott Moser cloud-init: importance Undecided Medium
2015-05-31 15:47:43 Nobuto Murata bug added subscriber Nobuto Murata
2016-12-04 02:37:52 Launchpad Janitor merge proposal linked https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/312424
2016-12-12 01:54:31 Scott Moser cloud-init: status Confirmed Fix Committed
2016-12-16 18:06:16 Scott Moser bug task added cloud-init (Ubuntu)
2016-12-16 18:06:32 Scott Moser cloud-init (Ubuntu): status New Fix Released
2016-12-16 18:06:36 Scott Moser cloud-init (Ubuntu): importance Undecided Low
2016-12-16 18:06:46 Scott Moser nominated for series Ubuntu Xenial
2016-12-16 18:06:46 Scott Moser bug task added cloud-init (Ubuntu Xenial)
2016-12-16 18:06:46 Scott Moser nominated for series Ubuntu Yakkety
2016-12-16 18:06:46 Scott Moser bug task added cloud-init (Ubuntu Yakkety)
2016-12-16 18:06:54 Scott Moser cloud-init (Ubuntu Yakkety): status New Confirmed
2016-12-16 18:06:57 Scott Moser cloud-init (Ubuntu Yakkety): importance Undecided Low
2016-12-16 18:07:00 Scott Moser cloud-init (Ubuntu Xenial): status New Confirmed
2016-12-16 18:07:04 Scott Moser cloud-init (Ubuntu Xenial): importance Undecided Low
2016-12-16 18:46:34 Scott Moser cloud-init (Ubuntu): status Fix Released Confirmed
2016-12-16 18:46:39 Scott Moser cloud-init: status Fix Committed Confirmed
2016-12-16 18:50:27 Launchpad Janitor merge proposal linked https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/313458
2016-12-16 20:32:42 Ubuntu Foundations Team Bug Bot tags patch
2016-12-16 20:32:52 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Review Team
2016-12-19 19:23:59 Launchpad Janitor cloud-init (Ubuntu): status Confirmed Fix Released
2016-12-19 21:43:40 Scott Moser description See downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1126365 === Begin SRU Template === [Impact] A specific usage of user data to cloud-init will fail to add a user. This cloud-config: #cloud-config users: - default - name: foobar gecos: "My User" groups: sudo, adm Will fail with information in the cloud-init log showing: 2016-12-19 21:39:32,713 - util.py[WARNING]: Failed to create group adm 2016-12-19 21:39:32,713 - util.py[DEBUG]: Failed to create group adm Traceback (most recent call last): ... cloudinit.util.ProcessExecutionError: Unexpected error while running command. Command: ['groupadd', ' adm'] Exit code: 3 Reason: - Stdout: '' Stderr: "groupadd: ' adm' is not a valid group name\n" While changing the last line to the following would work: groups: [sudo, adm] [Test Case] $ cat > user-data <"EOF" #cloud-config users: - default - name: foobar gecos: "My User" groups: sudo, adm - name: wark groups: [sudo, adm] $ release=yakkety $ name="$release-1354694" $ lxc launch "ubuntu-daily:$release" "$name" \ "--config=user.user-data=$(cat user-data)" $ sleep 10 ## Check foobar is in expected groups $ lxc exec $name -- groups foobar foobar : foobar adm sudo $ lxc exec $name -- groups wark wark : wark adm sudo $ lxc exec $name -- grep WARN /var/log/cloud-init.log || echo "no warn" no warn [Regression Potential] There are 3 changes in this commit a.) if 'groups' entry is a string, split on "," and strip pieces The most likely path to failure here is if previously a non-string (possibly bytes) was being passed in and now will be ignored. That seems unlikely and clearly wrong input. b.) fix and unit tests to explicitly set system=False or no_create_home=True. Previously those paths did not test the value of the entry, only the presense of the entry. This meant that these 2 configs were the same: users: {name: bob, system: True} and users: {name: bob, system: False} That bug is fixed here so that 'system: False' is just explicitly disabling the '--system' flag to adduser. c.) debug message cleanup: LOG.debug("created group %s for user %s", name, group) LOG.debug("created group '%s' for user '%s'", group, name) [Other Info] Upstream commit at https://git.launchpad.net/cloud-init/commit/?id=ca3ae67211d907b4cfdcd685c0ae4f9530cb7da1 === End SRU Template === See downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1126365
2016-12-22 20:21:25 Scott Moser cloud-init: status Confirmed Fix Committed
2016-12-23 17:34:20 Scott Moser cloud-init: status Fix Committed Fix Released
2016-12-23 17:35:19 Scott Moser cloud-init: status Fix Released Fix Committed
2016-12-23 17:36:41 Scott Moser cloud-init: status Fix Committed Fix Released
2017-01-12 19:45:28 Brian Murray cloud-init (Ubuntu Yakkety): status Confirmed Fix Committed
2017-01-12 19:45:31 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2017-01-12 19:45:39 Brian Murray bug added subscriber SRU Verification
2017-01-12 19:45:44 Brian Murray tags patch patch verification-needed
2017-01-20 16:28:22 Scott Moser description === Begin SRU Template === [Impact] A specific usage of user data to cloud-init will fail to add a user. This cloud-config: #cloud-config users: - default - name: foobar gecos: "My User" groups: sudo, adm Will fail with information in the cloud-init log showing: 2016-12-19 21:39:32,713 - util.py[WARNING]: Failed to create group adm 2016-12-19 21:39:32,713 - util.py[DEBUG]: Failed to create group adm Traceback (most recent call last): ... cloudinit.util.ProcessExecutionError: Unexpected error while running command. Command: ['groupadd', ' adm'] Exit code: 3 Reason: - Stdout: '' Stderr: "groupadd: ' adm' is not a valid group name\n" While changing the last line to the following would work: groups: [sudo, adm] [Test Case] $ cat > user-data <"EOF" #cloud-config users: - default - name: foobar gecos: "My User" groups: sudo, adm - name: wark groups: [sudo, adm] $ release=yakkety $ name="$release-1354694" $ lxc launch "ubuntu-daily:$release" "$name" \ "--config=user.user-data=$(cat user-data)" $ sleep 10 ## Check foobar is in expected groups $ lxc exec $name -- groups foobar foobar : foobar adm sudo $ lxc exec $name -- groups wark wark : wark adm sudo $ lxc exec $name -- grep WARN /var/log/cloud-init.log || echo "no warn" no warn [Regression Potential] There are 3 changes in this commit a.) if 'groups' entry is a string, split on "," and strip pieces The most likely path to failure here is if previously a non-string (possibly bytes) was being passed in and now will be ignored. That seems unlikely and clearly wrong input. b.) fix and unit tests to explicitly set system=False or no_create_home=True. Previously those paths did not test the value of the entry, only the presense of the entry. This meant that these 2 configs were the same: users: {name: bob, system: True} and users: {name: bob, system: False} That bug is fixed here so that 'system: False' is just explicitly disabling the '--system' flag to adduser. c.) debug message cleanup: LOG.debug("created group %s for user %s", name, group) LOG.debug("created group '%s' for user '%s'", group, name) [Other Info] Upstream commit at https://git.launchpad.net/cloud-init/commit/?id=ca3ae67211d907b4cfdcd685c0ae4f9530cb7da1 === End SRU Template === See downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1126365 === Begin SRU Template === [Impact] A specific usage of user data to cloud-init will fail to add a user. This cloud-config:   #cloud-config   users:     - default     - name: foobar       gecos: "My User"       groups: sudo, adm Will fail with information in the cloud-init log showing: 2016-12-19 21:39:32,713 - util.py[WARNING]: Failed to create group adm 2016-12-19 21:39:32,713 - util.py[DEBUG]: Failed to create group adm Traceback (most recent call last): ... cloudinit.util.ProcessExecutionError: Unexpected error while running command. Command: ['groupadd', ' adm'] Exit code: 3 Reason: - Stdout: '' Stderr: "groupadd: ' adm' is not a valid group name\n" While changing the last line to the following would work:       groups: [sudo, adm] [Test Case] $ cat > user-data <<"EOF" #cloud-config users:   - default   - name: foobar     gecos: "My User"     groups: sudo, adm   - name: wark     groups: [sudo, adm] EOF $ release=yakkety $ name="$release-1354694" $ lxc launch "ubuntu-daily:$release" "$name" \      "--config=user.user-data=$(cat user-data)" $ sleep 10 ## Check foobar is in expected groups $ lxc exec $name -- groups foobar foobar : foobar adm sudo $ lxc exec $name -- groups wark wark : wark adm sudo $ lxc exec $name -- grep WARN /var/log/cloud-init.log || echo "no warn" no warn [Regression Potential] There are 3 changes in this commit a.) if 'groups' entry is a string, split on "," and strip pieces     The most likely path to failure here is if previously a non-string     (possibly bytes) was being passed in and now will be ignored.     That seems unlikely and clearly wrong input. b.) fix and unit tests to explicitly set system=False or no_create_home=True.     Previously those paths did not test the value of the entry, only the     presense of the entry.     This meant that these 2 configs were the same:       users: {name: bob, system: True}     and       users: {name: bob, system: False}     That bug is fixed here so that 'system: False' is just explicitly     disabling the '--system' flag to adduser. c.) debug message cleanup:    LOG.debug("created group %s for user %s", name, group)    LOG.debug("created group '%s' for user '%s'", group, name) [Other Info] Upstream commit at   https://git.launchpad.net/cloud-init/commit/?id=ca3ae67211d907b4cfdcd685c0ae4f9530cb7da1 === End SRU Template === See downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1126365
2017-01-20 16:50:19 Scott Moser tags patch verification-needed patch verification-done
2017-01-20 16:50:39 Scott Moser summary useradd crashes if group list contains whitespace on Fedora useradd crashes if group list contains whitespace
2017-01-30 18:17:35 Andy Whitcroft removed subscriber Ubuntu Stable Release Updates Team
2017-01-30 18:18:12 Launchpad Janitor cloud-init (Ubuntu Yakkety): status Fix Committed Fix Released
2017-02-06 15:42:55 Brian Murray cloud-init (Ubuntu Xenial): status Confirmed Fix Committed
2017-02-06 15:42:58 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2017-02-06 15:43:04 Brian Murray tags patch verification-done patch
2017-02-06 15:43:05 Brian Murray tags patch patch verification-needed
2017-02-09 02:20:37 Scott Moser tags patch verification-needed patch verification-done
2017-02-22 00:43:01 Launchpad Janitor cloud-init (Ubuntu Xenial): status Fix Committed Fix Released
2023-05-10 03:38:33 James Falcon bug watch added https://github.com/canonical/cloud-init/issues/2473