users: stanza doesn't install Ec2 SSH key for user

[Steven Hardy]

Related to bug 1100920, when you use the "old" users syntax, SSH keys for the user are installed, but if you use the "new" style users stanza, then they are not:

E.g:

user: bob

works OK (with the fix for #1100920, tested at rev 809)

However this does not (creates the user, but does not create/update the .ssh/authorized_keys):

users:
 - bob

Note I'm testing on openstack, and I want the key provided by the nova Ec2 metadata (DataSourceEc2) to be installed for the specified user.

I'm testing on Fedora, which has a default_user defined in /etc/cloud/cloud.cfg (attached) - this seems related, since the default ec2-user user is always installed (with .ssh/authorized_keys correctly populated), but the definition of a default user by the distribution seems to break the config I'm providing via nova.

AFAICS this is due to apply_credentials only being called for the default user, returned from ds.extract_default:

http://bazaar.launchpad.net/~cloud-init-dev/cloud-init/trunk/view/head:/cloudinit/config/cc_ssh.py#L110

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/2365