meta-data.yaml is not cloud-config, should not be identified as such

[Scott Moser]

meta-data provided for lxd images includes 'cloud-init-meta.tpl'
which ends up being rendered into
 /var/lib/cloud/seed/nocloud-net/meta-data
identifies itself as '#cloud-config'

It is not cloud-config, so we should remove that comment.
Cloud-init loads that file as yaml.

The easy fix is just to delete the '#cloud-config' line.

$ wget http://cloud-images.ubuntu.com/xenial/20171212/xenial-server-cloudimg-amd64-lxd.tar.xz -O meta-data.tar.xz
$ tar xvf meta-data.tar.xz
metadata.yaml
templates/
templates/cloud-init-network.tpl
templates/cloud-init-vendor.tpl
templates/hostname.tpl
templates/cloud-init-meta.tpl
templates/cloud-init-user.tpl

$ cat templates/cloud-init-meta.tpl
#cloud-config
instance-id: {{ container.name }}
local-hostname: {{ container.name }}
{{ config_get("user.meta-data", "") }}

[Joshua Powers (powersj)]

This was fixed with the related branch above and confirmed it is still fixed. Marking fix released.