[SRU] radosgw-admin's diagnostics are confusing if user data exists

[Ponnuvel Palaniyappan]

This is same as LP#1914584 but its original patch was wrong which was found out in SRU tests and that particular release went ahead without the patch. Since that LP is kind of in hard-to-follow/confusing states, opened this new bug to carry out the SRU work.

----------

[Impact]

When creating a new S3 user, the error message is confusing if the email address used is already associated with another S3 account.

To reproduce:

radosgw-admin user create --uid=foo --display-name="Foo test" --<email address hidden>
#[ success ]
radosgw-admin user create --uid=test --display-name="AN test" --<email address hidden>
could not create user: unable to parse parameters, user id mismatch, operation id: foo does not match: test

As a result, it's completely unclear what went wrong with the user creation.

[Test case]

Create an S3 account via radosgw-admin. Then create another user but use
the same email address - it should provide a clear description of what
the problem is.

[Where problems could occur]

The new message may yet be unclear or could complain that an email exists even though it doesn't exist (false positive). It's an improved diagnostic by checking if the email id exists. Perhaps, user creation might become problematic if the fix doesn't work.

[Other Info]
- The patch was provided by Ponnuvel Palaniyappan (attached here)
- Upstream tracker: https://tracker.ceph.com/issues/50554
- Upstream PR: https://github.com/ceph/ceph/pull/41065
- Backported to Pacific, and Octopus upstream releases.

[nikhil kshirsagar (nkshirsagar)]

Attaching debdiff built on focal for octopus

[James Page (james-page)]

Looking at the upstream tracker I believe this fix is included in the 15.2.14-0ubuntu0.20.04.1 that's already in focal-proposed.

[James Page (james-page)]

The fix will also be included in the 16.2.6 release (for impish and hirsute) however that's not release yet.

Anything prior to octopus is now considered EOL by upstream so we'll need to decide whether to patch UCA and Ubuntu series with Nautilus or earlier releases.

[James Page (james-page)]

16.2.6 will be SRU'ed under bug 1943932

[Chris MacNaughton (chris.macnaughton)]

I've confirmed that James is correct re: 15.2.14, it was fix-released in Focal (& Ussuri) via bug 1940902

[Chris MacNaughton (chris.macnaughton)]

Also, Victoria isn't carrying Ceph in the UCA, so I'm marking that task as invalid