[SRU] openvswitch 2.9.7

[James Page]

[Impact]
This release sports mostly bug-fixes and we would like to make sure all of our users have access to these improvements.
The update contains the following package updates:

   * openvswitch 2.9.7

[Test Case]

The following SRU process was followed:

https://wiki.ubuntu.com/OpenStack/StableReleaseUpdates

In order to avoid regression of existing consumers, the OpenStack team will run their continuous integration test against the packages that are in -proposed. A successful run of all available tests will be required before the proposed packages can be let into -updates.

The OpenStack team will be in charge of attaching the output summary of the executed tests. The OpenStack team members will not mark ‘verification-done’ until this has happened.

[Regression Potential]
In order to mitigate the regression potential, the results of the
aforementioned tests are attached to this bug.

[Robie Basak (racb)]

13:02 <rbasak> jamespage: o/ reviewing bug 1881077. Where did you get the orig tarba
ll from?

13:03 <rbasak> There's a bunch of noise in the diff - looks like a switch to a git s
napshot so missing autoconf

13:03 <rbasak> I noticed you changed the watch file

13:03 <rbasak> But that's still a .gz, and the orig tarball you uploaded is an .xz a
nd I can't find that anywhere

13:59 <jamespage> rbasak: hmm odd - let me check

13:59 <jamespage> I'm pretty sure I uscan'ed but can't remember specifically

14:01 <rbasak> Thanks. I don't see any specific problem but it did seem odd so I thought I'd ask in case it was unintentional.

[James Page (james-page)]

Revisited the orig.tar.* oddity today - 2.9.6 release tarball got lost somewhere during publishing upstream however I was able to locate it, removing the need to use a snapshot as I uploaded before.

Please reject the original 2.9.6-0ubuntu0.18.04.1 upload in preference to the smaller diff'ed one I uploaded today.

[Robie Basak (racb)]

Thank you for preparing the revised upload.

I've spent some time trying to reduce the review size here, but despite some help from James in #ubuntu-devel I've not managed to understand how the current orig tarball in the queue comes about.

I found https://www.openvswitch.org/releases/openvswitch-2.9.6.tar.gz but that mismatches the uploaded orig tarball quite a bit - mostly in autoconf, including in the areas of some (I think autoconf-) generated testsuites. It looks like the upstream tarball hasn't had autoconf run, but the uploaded orig tarball has had this done. Or are you using a different source?

I'm not confident in reviewing this without understanding how the orig tarball comes about. Please could you provide steps to reproduce the orig tarball?

[Timo Aaltonen (tjaalton)]

there's a 2.9.7 release available, maybe sort the tarball issue using that instead?

[Robie Basak (racb)]

As it doesn't look like this is going to make any progress, I'm rejecting it from the queue to clean up.

[Corey Bryant (corey.bryant)]

2.9.7 has been uploaded to the bionic unapproved queue

[Łukasz Zemczak (sil2100)]

The 2.9.7 tarball seems better (it's identical to the one via the watch file URL minus the debian/ directory), so I'll proceed with the review.

[Łukasz Zemczak (sil2100)]

Hello James, or anyone else affected,

Accepted openvswitch into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openvswitch/2.9.7-0ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted openvswitch (2.9.7-0ubuntu0.18.04.1) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

mininet/2.2.2-2ubuntu1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#openvswitch

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Corey Bryant (corey.bryant)]

Hello James, or anyone else affected,

Accepted openvswitch into queens-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:queens-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-queens-needed to verification-queens-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-queens-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Verified successfully on bionic-proposed. Tempest results are as follows:

10:21:12 ======
10:21:12 Totals
10:21:12 ======
10:21:12 Ran: 97 tests in 1469.5150 sec.
10:21:12 - Passed: 89
10:21:12 - Skipped: 8
10:21:12 - Expected Fail: 0
10:21:12 - Unexpected Success: 0
10:21:12 - Failed: 0
10:21:12 Sum of execute time for each test: 1250.2341 sec.

[Corey Bryant (corey.bryant)]

Verified successfully on queens-proposed. Tempest results are as follows:

10:30:57 ======
10:30:57 Totals
10:30:57 ======
10:30:57 Ran: 97 tests in 769.0470 sec.
10:30:57 - Passed: 89
10:30:57 - Skipped: 8
10:30:57 - Expected Fail: 0
10:30:57 - Unexpected Success: 0
10:30:57 - Failed: 0
10:30:57 Sum of execute time for each test: 637.8642 sec.

[Launchpad Janitor (janitor)]

This bug was fixed in the package openvswitch - 2.9.7-0ubuntu0.18.04.2

---------------
openvswitch (2.9.7-0ubuntu0.18.04.2) bionic-security; urgency=medium

  * SECURITY UPDATE: buffer overflow decoding malformed packets in lldp
    - debian/patches/CVE-2015-8011.patch: check lengths in lib/lldp/lldp.c.
    - CVE-2015-8011
  * SECURITY UPDATE: Externally triggered memory leak in lldp
    - debian/patches/CVE-2020-27827.patch: properly free memory in
      lib/lldp/lldp.c.
    - CVE-2020-27827

 -- Marc Deslauriers <email address hidden> Fri, 08 Jan 2021 07:30:25 -0500

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for openvswitch has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package openvswitch - 2.9.7-0ubuntu0.18.04.1~cloud0
---------------

 openvswitch (2.9.7-0ubuntu0.18.04.1~cloud0) xenial-queens; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 openvswitch (2.9.7-0ubuntu0.18.04.1) bionic; urgency=medium
 .
   [ James Page ]
   * d/rules: Skip execution of dh_systemd_start for openvswitch-switch
     subunits avoiding multiple restarts during package configuration
     (LP: #1823295).
   * d/watch: Update for changes in upstream website.
 .
   [ Corey Bryant ]
   * d/openvswitch-switch.ovs*.service: Update ovs-vswitchd and ovsdb-server
     systemd unit files to use the correct environment file and environment
     variable for ovs-ctl options, /etc/default/openvswitch-switch and
     OVS_CTL_OPTS, respectively (LP: #1906280).
   * New upstream point release (LP: #1881077).