Unable to use 'Any' availability zone when spawning instance

[sergiiF]

[Impact]
While using Mitaka, we found that by default, using js backend, it is not possible to choose 'any' availability zone. The issue is not fixed in master branch.

For python implementation the logic is:
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#L390

The JS implementation miss the logic if number of AZs is >1
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js#L321

Also, JS implementation looks ugly if you have lot of subnets per network...

[Test Case]
Ensure that in the Angular Launch Instance, if there is more than one availability zone, it defaults to the option of Nova scheduler picking the AZ.

[Regression Potential]
Regression potential is fairly low. This bug has been fixed in all releases of OpenStack starting with Newton. The patch did have to be modified slightly to apply to mitaka.

[Matt Borland (palecrow)]

We've experienced this bug as well. Looking into it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/362230

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/362230
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=be6bcef45289ce1a934db478e5c9c7705890af18
Submitter: Jenkins
Branch: master

commit be6bcef45289ce1a934db478e5c9c7705890af18
Author: Matt Borland <email address hidden>
Date: Mon Aug 29 09:54:56 2016 -0600

    Let Nova to pick availability zone if more than 1

    In the Angular Launch Instance, if there is more than one availability zone,
    default to the option for the Nova scheduler to pick. This is a regression
    from the legacy Launch Instance feature.

    If you want to simulate testing the logic with multiple avaiability zones,
    go to: .../launch-instance/launch-instance-model.service.js line 785 and add:

    model.availabilityZones.push({label: 'another one', value: 'another one'});

    Change-Id: Ib81447382bc9d43e33ce97f78c085d2a94ff2018
    Closes-Bug: 1613900

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/408966

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 11.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/426170

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 10.0.2 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Radomir Dopieralski (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/426170
Reason: Let me just abandon this.

[Shane Peters (shaner)]

Backport of patch to Mitaka for Ubuntu Cloud Archive.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "horizon_9.1.2-0ubuntu4.patch" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Corey Bryant (corey.bryant)]

Adding SRU details for Ubuntu.

[Impact]
See bug description above.

[Test Case]
Ensure that in the Angular Launch Instance, if there is more than one availability zone, it defaults to the option of Nova scheduler picking the AZ.

[Regression Potential]
Regression potential is fairly low. This bug has been fixed in all releases of OpenStack starting with Newton. The patch did have to be modified slightly to apply to mitaka.

[Discussion]

[Corey Bryant (corey.bryant)]

Thanks Shane. I've uploaded a new version of horizon with your patch to the xenial review queue where the SRU team will review.

[Shane Peters (shaner)]

Thanks Corey!

[Łukasz Zemczak (sil2100)]

Hello sergiiF, or anyone else affected,

Accepted horizon into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/horizon/2:9.1.2-0ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Hello sergiiF, or anyone else affected,

Accepted horizon into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:mitaka-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-mitaka-needed to verification-mitaka-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-mitaka-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

Hello sergiiF, or anyone else affected,

Accepted horizon into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/horizon/2:9.1.2-0ubuntu5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Hello sergiiF, or anyone else affected,

Accepted horizon into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:mitaka-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-mitaka-needed to verification-mitaka-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-mitaka-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for horizon has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package horizon - 2:9.1.2-0ubuntu5~cloud0
---------------

 horizon (2:9.1.2-0ubuntu5~cloud0) trusty-mitaka; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 horizon (2:9.1.2-0ubuntu5) xenial; urgency=medium
 .
   [ Seyeong Kim ]
   * Hide unused consistency groups tab (LP: #1582725)
     - d/p/hide-unused-consistency-groups.patch: Pick some policies from
       upstream commit 388708b251b0487bb22fb3ebb8fcb36ee4ffdc4f to hide
       unused consistency groups tab.
 .
   [ Corey Bryant ]
   * d/openstack-dashboard.postinst: Ensure permissions are not
     world-readable for /etc/openstack-dashboard/local_settings.py
     (LP: #1755027).
 .
   [ Shane Peters ]
   * d/p/let-nova-to-pick-availability-zone.patch:
     In the Angular Launch Instance, if there is more than one
     availability zone default to the option for the Nova scheduler to pick.
     This is regression from the legacy Launch Instance feature (LP: #1613900).

[Łukasz Zemczak (sil2100)]

I will be conditionally accepting this package verification this one time, but please remember to *always* include test logs for any verification that has been performed. We, the SRU team, need to know what tests have been performed and on which package versions. It is not acceptable just to switch the tag in such case as we then have no idea if the package was in fact tested or not.

[Launchpad Janitor (janitor)]

This bug was fixed in the package horizon - 2:9.1.2-0ubuntu5

---------------
horizon (2:9.1.2-0ubuntu5) xenial; urgency=medium

  [ Seyeong Kim ]
  * Hide unused consistency groups tab (LP: #1582725)
    - d/p/hide-unused-consistency-groups.patch: Pick some policies from
      upstream commit 388708b251b0487bb22fb3ebb8fcb36ee4ffdc4f to hide
      unused consistency groups tab.

  [ Corey Bryant ]
  * d/openstack-dashboard.postinst: Ensure permissions are not
    world-readable for /etc/openstack-dashboard/local_settings.py
    (LP: #1755027).

  [ Shane Peters ]
  * d/p/let-nova-to-pick-availability-zone.patch:
    In the Angular Launch Instance, if there is more than one
    availability zone default to the option for the Nova scheduler to pick.
    This is regression from the legacy Launch Instance feature (LP: #1613900).

 -- Corey Bryant <email address hidden> Thu, 15 Mar 2018 13:57:14 -0400