[SRU] InstanceList.get_by_security_group_id can run very slow
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Paul Griffin | ||
Mitaka |
Fix Released
|
Medium
|
Unassigned | ||
Ubuntu Cloud Archive |
Invalid
|
Undecided
|
Unassigned | ||
Liberty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
Backporting to Liberty Ubuntu Cloud Archive from Mitaka. The backport is
fairly simple and clean with the exception of extra two unit tests that
had to be ammended in order to work. The Liberty codebase still has the
ec2 api code that is deprecated in Kilo and subsequently removed in Mitaka
and there is a unit test for that api that was failing.
[Test Case]
* Deploy Openstack Liberty with this patch
* Populate some security groups and create/delete some instances, checking
that the security groups are functioning properly.
* Run full Tempest test suite (rev 13.0.0) against deployed cloud.
[Regression Potential]
This patch has not received any testing with the ec2 api in future releases
due the fact that that api is removed in M. Tempest did not find any errors
when testing against L though so I not envisaging any regressions.
-------
The nova.objects.
If a group-source secgroup-rule exists on a security group with a large number of instances and a large number of rules, the db query result will be very large and take multiple seconds to complete, tying up conductor and making the system unresponsive.
Since the InstanceList.
Changed in nova: | |
assignee: | nobody → Paul Griffin (paul-griffin) |
description: | updated |
description: | updated |
Changed in nova: | |
assignee: | Paul Griffin (paul-griffin) → John Garbutt (johngarbutt) |
tags: | added: api performance security-groups |
Changed in nova: | |
assignee: | John Garbutt (johngarbutt) → Paul Griffin (paul-griffin) |
importance: | Undecided → Medium |
tags: | added: nova-network |
tags: | added: sts sts-sru |
tags: |
added: sts-sru-needed removed: sts-sru |
tags: |
added: sts-sru-done removed: sts-sru-needed |
Fix proposed to branch: master /review. openstack. org/288548
Review: https:/