Ubuntu Cloud Archive

[OVN] ``PortBindingChassisEvent`` event is not executing the conditions check

Bug #2037717 reported by Rodolfo Alonso
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Cloud Archive
New
Undecided
Unassigned
Ussuri
New
Undecided
Unassigned
Victoria
New
Undecided
Unassigned
Wallaby
Fix Released
Undecided
Unassigned
neutron
Fix Released
High
Rodolfo Alonso
neutron (Ubuntu)
New
Undecided
Unassigned
Focal
New
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned

Bug Description

Since [1], that overrides the "match_fn" method, the event is not checking the defined conditions in the initialization, that are:
  ('type', '=', ovn_const.OVN_CHASSIS_REDIRECT)

[1]https://review.opendev.org/q/I3b7c5d73d2b0d20fb06527ade30af8939b249d75

Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2241824

See original description
Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
importance: Undecided → High
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/896926

Changed in neutron:
status: New → In Progress
Lajos Katona (lajos-katona)
tags: added: bobcat-backport-potential ovn
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/897019

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/897020

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/897041

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/897043

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/897044

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/897045

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/896926
Committed: https://opendev.org/openstack/neutron/commit/a76aa019772cc35b07a404c213b327169c188243
Submitter: "Zuul (22348)"
Branch: master

commit a76aa019772cc35b07a404c213b327169c188243
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Sep 28 19:52:41 2023 +0000

    [OVN] Add the default condition check in ``PortBindingChassisEvent``

    The event ``PortBindingChassisEvent`` should be executed only if the
    initialization condition "type=ovn_const.OVN_CHASSIS_REDIRECT" is met.

    This condition was skipped since [1], where the ``match_fn`` was
    overriden.

    [1]https://review.opendev.org/q/I3b7c5d73d2b0d20fb06527ade30af8939b249d75

    Closes-Bug: #2037717
    Change-Id: I01fa481456c0a675b5857d9796b8323493e4fbc1

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/897019
Committed: https://opendev.org/openstack/neutron/commit/61f94ab4493c981cea4844b5947f5699352c7fe7
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 61f94ab4493c981cea4844b5947f5699352c7fe7
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Sep 28 19:52:41 2023 +0000

    [OVN] Add the default condition check in ``PortBindingChassisEvent``

    The event ``PortBindingChassisEvent`` should be executed only if the
    initialization condition "type=ovn_const.OVN_CHASSIS_REDIRECT" is met.

    This condition was skipped since [1], where the ``match_fn`` was
    overriden.

    [1]https://review.opendev.org/q/I3b7c5d73d2b0d20fb06527ade30af8939b249d75

    Closes-Bug: #2037717
    Change-Id: I01fa481456c0a675b5857d9796b8323493e4fbc1
    (cherry picked from commit a76aa019772cc35b07a404c213b327169c188243)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/897020
Committed: https://opendev.org/openstack/neutron/commit/de329d2828d7b8cb814a504c02c3e272d058e4d9
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit de329d2828d7b8cb814a504c02c3e272d058e4d9
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Sep 28 19:52:41 2023 +0000

    [OVN] Add the default condition check in ``PortBindingChassisEvent``

    The event ``PortBindingChassisEvent`` should be executed only if the
    initialization condition "type=ovn_const.OVN_CHASSIS_REDIRECT" is met.

    This condition was skipped since [1], where the ``match_fn`` was
    overriden.

    [1]https://review.opendev.org/q/I3b7c5d73d2b0d20fb06527ade30af8939b249d75

    Closes-Bug: #2037717
    Change-Id: I01fa481456c0a675b5857d9796b8323493e4fbc1
    (cherry picked from commit a76aa019772cc35b07a404c213b327169c188243)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/897044
Committed: https://opendev.org/openstack/neutron/commit/45dab8b83b5ac4e9926c42e088a5d2e53e890858
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 45dab8b83b5ac4e9926c42e088a5d2e53e890858
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Sep 28 19:52:41 2023 +0000

    [OVN] Add the default condition check in ``PortBindingChassisEvent``

    The event ``PortBindingChassisEvent`` should be executed only if the
    initialization condition "type=ovn_const.OVN_CHASSIS_REDIRECT" is met.

    This condition was skipped since [1], where the ``match_fn`` was
    overriden.

    [1]https://review.opendev.org/q/I3b7c5d73d2b0d20fb06527ade30af8939b249d75

    Conflicts:
        neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py

    Closes-Bug: #2037717
    Change-Id: I01fa481456c0a675b5857d9796b8323493e4fbc1
    (cherry picked from commit a76aa019772cc35b07a404c213b327169c188243)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/897041
Committed: https://opendev.org/openstack/neutron/commit/3597474477f64bc93bdee03d369058bc3e858705
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 3597474477f64bc93bdee03d369058bc3e858705
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Sep 28 19:52:41 2023 +0000

    [OVN] Add the default condition check in ``PortBindingChassisEvent``

    The event ``PortBindingChassisEvent`` should be executed only if the
    initialization condition "type=ovn_const.OVN_CHASSIS_REDIRECT" is met.

    This condition was skipped since [1], where the ``match_fn`` was
    overriden.

    [1]https://review.opendev.org/q/I3b7c5d73d2b0d20fb06527ade30af8939b249d75

    Closes-Bug: #2037717
    Change-Id: I01fa481456c0a675b5857d9796b8323493e4fbc1
    (cherry picked from commit a76aa019772cc35b07a404c213b327169c188243)

tags: added: in-stable-zed
tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/897043
Committed: https://opendev.org/openstack/neutron/commit/20ed2fcbb1d8166633283d0531ee6336d1341a33
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 20ed2fcbb1d8166633283d0531ee6336d1341a33
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Sep 28 19:52:41 2023 +0000

    [OVN] Add the default condition check in ``PortBindingChassisEvent``

    The event ``PortBindingChassisEvent`` should be executed only if the
    initialization condition "type=ovn_const.OVN_CHASSIS_REDIRECT" is met.

    This condition was skipped since [1], where the ``match_fn`` was
    overriden.

    [1]https://review.opendev.org/q/I3b7c5d73d2b0d20fb06527ade30af8939b249d75

    Conflicts:
        neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py

    Closes-Bug: #2037717
    Change-Id: I01fa481456c0a675b5857d9796b8323493e4fbc1
    (cherry picked from commit a76aa019772cc35b07a404c213b327169c188243)
    (cherry picked from commit 45dab8b83b5ac4e9926c42e088a5d2e53e890858)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/897045
Committed: https://opendev.org/openstack/neutron/commit/b19da937d7cba753fd3c6fb4d3636a084c934a42
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit b19da937d7cba753fd3c6fb4d3636a084c934a42
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Sep 28 19:52:41 2023 +0000

    [OVN] Add the default condition check in ``PortBindingChassisEvent``

    The event ``PortBindingChassisEvent`` should be executed only if the
    initialization condition "type=ovn_const.OVN_CHASSIS_REDIRECT" is met.

    This condition was skipped since [1], where the ``match_fn`` was
    overriden.

    [1]https://review.opendev.org/q/I3b7c5d73d2b0d20fb06527ade30af8939b249d75

    Conflicts:
        neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py

    Closes-Bug: #2037717
    Change-Id: I01fa481456c0a675b5857d9796b8323493e4fbc1
    (cherry picked from commit a76aa019772cc35b07a404c213b327169c188243)
    (cherry picked from commit 45dab8b83b5ac4e9926c42e088a5d2e53e890858)

tags: added: in-stable-wallaby
Rodolfo Alonso (rodolfo-alonso-hernandez)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.1.0

This issue was fixed in the openstack/neutron 22.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 23.1.0

This issue was fixed in the openstack/neutron 23.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.5.0

This issue was fixed in the openstack/neutron 20.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.2.0

This issue was fixed in the openstack/neutron 21.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/903500

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/903502

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 24.0.0.0b1

This issue was fixed in the openstack/neutron 24.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/ussuri)

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/903502
Reason: This branch of the project transitioned to End of Life. Open patches need to be abandoned.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/victoria)

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/903500
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Brian Haley (brian-haley)
Changed in neutron (Ubuntu Jammy):
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron wallaby-eom

This issue was fixed in the openstack/neutron wallaby-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron xena-eom

This issue was fixed in the openstack/neutron xena-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.