[SRU] Fix None comparison when sorting by `updated_at`
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Cloud Archive |
Fix Released
|
Undecided
|
Unassigned | ||
Ussuri |
Fix Released
|
Undecided
|
Unassigned | ||
Victoria |
Fix Released
|
Undecided
|
Unassigned | ||
Wallaby |
Fix Released
|
Undecided
|
Unassigned | ||
Xena |
Fix Released
|
Undecided
|
Unassigned | ||
Yoga |
Fix Released
|
Undecided
|
Unassigned | ||
Zed |
Fix Released
|
Undecided
|
Unassigned | ||
heat (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
StoryBoard link: https:/
[Impact]
If resource candidates were never updated before then their `updated_at` value in the db remain `None`.
This prevents future resource updates when any of of the resources in db has been replaced without being updated before.
[Test Plan]
A. Reproducer steps:
1. create a project and nova instances using > 1 vcpus in that project
2. create a stack with a OS::Nova::Quota resource managing the project's quotas
3. change the vcpu quota to an invalid value (i.e. 0) and update the stack three times
4. set a valid quota and update the stack again
Then stack update will fail with the message:
"'<' not supported between instances of 'datetime.datetime' and 'NoneType'"
(openstack stack show <stackname>)
B. Install the heat package with fix, restart heat service
C. Re-run step 4 from reproducer steps again (update the stack once again)
D. Confirm that resource update succeeds and the stack update shows 'UPDATE_COMPLETE' with no errors (can repeat several times as well) or fails with a different message for another reason
[Where problems could occur]
If the `created_at` value happens to `None` as well for some reason then this will end up failing in the same manner.
Newer OpenStack versions already contain this fix and released packages (Wallaby, Yoga, and Zed) work as expected.
[Other info]
The fix was backported to Ussuri after the last release of Heat (14.2).
Upstream PR: https:/
This was impacting a user who is using Ussuri. Latest releases already contain the fix in the following packages:
Wallaby: heat_16.
Yoga: heat_18.
Zed: heat_19.
Related branches
- Ubuntu OpenStack uploaders: Pending requested
-
Diff: 145 lines (+125/-0)3 files modifieddebian/changelog (+7/-0)
debian/patches/lp2019175.patch (+117/-0)
debian/patches/series (+1/-0)
- Ubuntu OpenStack uploaders: Pending requested
-
Diff: 145 lines (+125/-0)3 files modifieddebian/changelog (+7/-0)
debian/patches/lp2019175.patch (+117/-0)
debian/patches/series (+1/-0)
affects: | puppet-heat → cloud-archive |
summary: |
- bug fixed and backported but not released in package + [SRU] Fix None comparision when sorting by `updated_at` |
description: | updated |
Changed in heat (Ubuntu): | |
status: | New → Fix Released |
Changed in cloud-archive: | |
status: | New → Fix Released |
summary: |
- [SRU] Fix None comparision when sorting by `updated_at` + [SRU] Fix None comparison when sorting by `updated_at` |
description: | updated |
Changed in heat (Ubuntu Jammy): | |
status: | New → Fix Released |
Changed in heat (Ubuntu Focal): | |
status: | Incomplete → Fix Committed |
really sorry... this belongs into python-heat, not puppet-heat