[SRU] Fix for KeyError: 'storage.zfs_pool_name' only partially successful -- needs changes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
LXD Charm |
Fix Released
|
Critical
|
Alex Kavanagh | ||
Ubuntu Cloud Archive |
Won't Fix
|
High
|
Unassigned | ||
Queens |
Won't Fix
|
High
|
Unassigned | ||
Rocky |
Won't Fix
|
High
|
Unassigned | ||
nova-lxd |
Won't Fix
|
Undecided
|
Unassigned | ||
nova-lxd (Ubuntu) |
Won't Fix
|
High
|
Unassigned | ||
Bionic |
Won't Fix
|
High
|
Unassigned | ||
Cosmic |
Won't Fix
|
High
|
Unassigned |
Bug Description
[Impact]
The issue is that the fix was only partially successful, in that whilst it avoids the 'storage.
The LXD charm used different names (it's now being patched to use the same name for the lxd pool and zfs pool), which broke nova-lxd on bionic.
The code in question is in nova/virt/
try:
except KeyError:
i.e. storage.
When nova-lxd is properly refactored for storage pools, this issue should be resolved.
[Test Case]
[Regression Potential]
[Discussion]
Changed in charm-lxd: | |
assignee: | nobody → Alex Kavanagh (ajkavanagh) |
importance: | Undecided → Critical |
status: | New → In Progress |
Changed in nova-lxd (Ubuntu Bionic): | |
status: | New → Triaged |
Changed in nova-lxd (Ubuntu Cosmic): | |
status: | New → Triaged |
Changed in nova-lxd (Ubuntu Bionic): | |
importance: | Undecided → High |
Changed in nova-lxd (Ubuntu Cosmic): | |
importance: | Undecided → High |
summary: |
- Fix for KeyError: 'storage.zfs_pool_name' only partially successful -- - needs changes + [SRU] Fix for KeyError: 'storage.zfs_pool_name' only partially + successful -- needs changes |
description: | updated |
Changed in charm-lxd: | |
milestone: | none → 19.04 |
Changed in charm-lxd: | |
status: | Fix Committed → Fix Released |
Changed in nova-lxd: | |
status: | New → Won't Fix |
Changed in cloud-archive: | |
status: | Triaged → Won't Fix |
Changed in nova-lxd (Ubuntu): | |
status: | Triaged → Won't Fix |
Changed in nova-lxd (Ubuntu Cosmic): | |
status: | Triaged → Won't Fix |
Changed in nova-lxd (Ubuntu Bionic): | |
status: | Triaged → Won't Fix |
Reviewed: https:/ /review. openstack. org/583499 /git.openstack. org/cgit/ openstack/ charm-lxd/ commit/ ?id=4d7b3e92400 8af878b0c369c1b d3e92238d51a93
Committed: https:/
Submitter: Zuul
Branch: master
commit 4d7b3e924008af8 78b0c369c1bd3e9 2238d51a93
Author: Chris MacNaughton <email address hidden>
Date: Wed Jul 18 10:21:03 2018 +0200
Remove old nova-compute / mysql relation and patch for nova-lxd bug
This review is modified to include a patch to resolve bug #1793137 zfs_pool_ name key
which is due to a bug in nova-lxd where the wrong pool name (lxd) is
used with zfs if lxd is new enough that the storage.
is missing from the config. This is the case on bionic and snap
installed lxd.
Closes-Bug: #1713807 e9183424b363fc3 d1ff25f2346
Related-Bug: #1793137
Change-Id: I1123d9882bdb00