Horizon incorrectly release floating IPs instead disassociate them

[George Shuklin]

Horizon has two places to disassociate floating IPs from instances:
1. Instances->More->Disassociate Floating IP
2. Access & Security -> Floating IPs -> Disassociate.

Second option works fine, but first not just disassociate floating IP, but also release it from tenant. This cause confusion for users (associate floating ip, disassociate floating ip, repeat few times and there is no more free ip for tenant to associate).

Preparation:
1) create external network with some ip to be allocated as floating IP with neutron
2) create internal network
3) create router between them
4) create instance
5) Allocate floating IP to tenant.
6) Associate floating IP to instance

Steps to reproduce:

1) In 'Project' click 'Instances'
2) For instance with floating IP click 'More'
3) Click 'Disassociate Floating IP'
4) Click confirmation button 'Disassociate Floating IP'

Expected behavior:
Floating IP disassociate from instance, but available for future association

Actual behavior:
Floating IP removed from tenant and no longer available for association.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: python-django-horizon 1:2013.2-0ubuntu1~cloud0 [origin: Canonical]
ProcVersionSignature: Ubuntu 3.2.0-57.87-generic 3.2.52
Uname: Linux 3.2.0-57-generic x86_64
ApportVersion: 2.0.1-0ubuntu17.6
Architecture: amd64
CrashDB: cloud_archive
Date: Tue Dec 17 03:42:49 2013
MarkForUpload: True
PackageArchitecture: all
SourcePackage: horizon
UpgradeStatus: No upgrade log present (probably fresh install)

[James Page (james-page)]

This is a duplicate of bug 1247245 which was fixed in 2013.2.4 and in 2014.1

Marking 'Fix Released'