Prolong-for option for lease-update doesn't accept negative values

[Christian Martinez]

Via pythonclient itself we can reduce the leases length, but the climate CLI only allows to prolong the lease.

The idea behind this bug (or bp, I prefer) is to allow the user to put a negative time within the lease-update arguments, so you can reduce the lease length easily and without to much effort

For instance:

climate lease-update --name "new name" --prolong-for "-1h"

should reduce the lease by an hour from the end_date.

Maybe, we should also change some of the doc related to the command, because it will be unclear for the user how to use this new option.

[Dina Belova (dbelova)]

Here is prolong-for option - https://github.com/stackforge/python-climateclient/blob/master/climateclient/v1/leases.py#L44
You should fit it somewhere here)

[Dina Belova (dbelova)]

You may even use not --prolong-for, but create some other option, for clear view for the user.

[Christian Martinez (christian-martinez)]

Thanks! I'll keep that in mind

[Christian Martinez (christian-martinez)]

This bug could be consider as bp (add new feature) and bug (partially implemented staff, forgotten to be done).
I'll add the functionality to make this work, but after that, we need to create a bp for the "other" option that Dina mentioned in the above comment.

[Christian Martinez (christian-martinez)]

What about smth like this:

$ climate help lease-update
usage: climate lease-update [-h] [--name NAME] [--prolong-for PROLONG_FOR]
                            [--reduce-by REDUCE_BY]
                            LEASE

positional arguments:
  LEASE ID or name of lease to delete

optional arguments:
  -h, --help show this help message and exit
  --name NAME New name for the lease
  --prolong-for PROLONG_FOR
                        Time to prolong lease for
  --reduce-by REDUCE_BY
                        Time to reduce lease by

The reduce-by option will make the call. Is that makes sense?
What would happen if the user puts the two options at the same time?

[Christian Martinez (christian-martinez)]

I uploaded a patch with this new argument. No need to create a bp (at least for now)

[Christian Martinez (christian-martinez)]

Fixed with https://review.openstack.org/#/c/87684/