Blazar

PEP8 fails on Climate client with a "H302 import only modules"

Bug #1276642 reported by Pablo Andres Fuente
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Blazar
Fix Released
Medium
Pablo Andres Fuente
Blazar 0.1.1

Bug Description

This is the output:

pep8 create: /opt/stack/python-climateclient/.tox/pep8
pep8 installdeps: -r/opt/stack/python-climateclient/test-requirements.txt
pep8 inst: /opt/stack/python-climateclient/.tox/dist/python-climateclient-0.1.0.zip
pep8 runtests: commands[0] | flake8
./climateclient/openstack/common/strutils.py:26:1: H302 import only modules.'from climateclient.openstack.common.gettextutils import _' does not import a module
from climateclient.openstack.common.gettextutils import _
^
ERROR: InvocationError: '/opt/stack/python-climateclient/.tox/pep8/bin/flake8'

This could be solved adding # noqa as in climateclient/v1/leases.py

Pablo Andres Fuente (pablo-a-fuente)
Changed in climate:
assignee: nobody → Pablo Andres Fuente (pablo-a-fuente)
Revision history for this message
Dina Belova (dbelova) wrote :

Please use excluding rule in tox.ini for that as in climate repo itself. openstack/common code is not a thing we should fix in climate :)

Changed in climate:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 0.1.1
Revision history for this message
Dina Belova (dbelova) wrote :

https://review.openstack.org/#/c/71284/ - fix committed

Changed in climate:
status: Triaged → Fix Committed
Masahito Muroi (muroi-masahito)
Changed in blazar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.