Buttons key shortcuts missing

[David Caro]

The buttons Run and Edit do not have an Alt+key shortcut.
To add it you must add an underscore before the letter for the shortcut when setting the button name, it seems that it must be done in the mo files (transslations) so when getting _('Run') the result must be '_Run' (in english).

I can do it myself, but i'm not sure how to edit the translations (.mo files).

[Marek Bardoński (bdfhjk)]

Hi David!

Thanks for all your work. I look at patchs and bugs reported by You,
when I end participating in NASA tournament, that consumed my time.

Maybe You thinking about joining our team?

About .mo files :

Try to look here : [1] , [2] and short tutorial [3]

Regards!

 Marek Bardoński

[1] http://www.gnu.org/software/gettext/manual/gettext.html
[2] http://docs.python.org/library/gettext.html
[3] http://oriya.sarovar.org/docs/gettext/

[David Caro (dcaro)]

Hi Marek,

Sure!

[David Caro (dcaro)]

I've changed that for spanish language, I will post the patch for all the files (and languages) here as soon as posible.

It's a little more complicated than i first thought:
The translation files (.mo) where not installed correctly, only one clicompanion.mo file was installed at the /usr/share/clicompanion/local/ dir,, fixed the setup.py file.

After that, all the key shortcuts are working :)

[Marek Bardoński (bdfhjk)]

I only want to notice, that we have automatic launchpad translation system, so better than make changes in all language files is modify .pot file. See in google 'automatic launchpad translations'.

Regards!

[David Caro (dcaro)]

Yes, I noticed :S

So I did not change the translations but added an underscore before the translation, so the first letter becomes the shortcut.

If more buttons are not going to use the stock, the same must be done for each one (now it uses the gtk.stock buttons, so they are correctly translated).

I've seen that ubuntu stores the translations sometimes as the locales are called (en_GB for example) but sometimes only as a general locale (es instead of es_ES for example) so now it looks for the fulll locale, and if not found, looks for the generic one.

I'll create another bug with the patch attached for this issue.

[Marek Bardoński (bdfhjk)]

I checked patch and recommend to merge it to trunk.

Thanks!

[David Caro (dcaro)]

Reopened and started a branch, the first patch does not work properly for the edit button.

[Marek Bardoński (bdfhjk)]

Edit button shortcut is now working fine. Closing then. Thanks!