Not doing the X-CLICK-TOKEN dance

Bug #1231422 reported by Alejandro J. Cura
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
clickmanager-plugin
High
Unassigned
clickmanager-plugin (Ubuntu)
Undecided
Unassigned
Saucy
Undecided
Unassigned

Bug Description

This plugin is passing the oauth signed url to the download manager, and that will fail if the download manager has stuff queued and it takes longer than 5 minutes because the oauth signature expires.

The solution to this are the X-CLICK-TOKEN headers, which are valid for 24 hours, but to get them you need to do a little dance:

1) this plugin will receive an unsigned url to download
2) this plugin will use oauth to sign this url with the users's U1 credentials
3) this plugin will do a HEAD request to the signed url, and retrieve the X-Click-Token header
4) this plugin will pass the *unsigned* url and the X-Click-Token to the download manager

Reference code for the dance can be found here: http://bazaar.launchpad.net/~ubuntuone-hackers/unity-scope-click/trunk/view/head:/src/download-manager.vala#L101

Related branches

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:clickmanager-plugin at revision 16, scheduled for release in clickmanager-plugin, milestone Unknown

Changed in clickmanager-plugin:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package clickmanager-plugin - 0.1+14.04.20140306-0ubuntu1

---------------
clickmanager-plugin (0.1+14.04.20140306-0ubuntu1) trusty; urgency=low

  [ CI bot ]
  * No change rebuild against Qt 5.2.1.

  [ Diego Sarmentero ]
  * Add x-click-token support. (LP: #1231422)

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Thu, 06 Mar 2014 09:25:29 +0000

Changed in clickmanager-plugin (Ubuntu):
status: New → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

saucy has seen the end of its life and is no longer receiving any updates. Marking the saucy task for this ticket as "Won't Fix".

Changed in clickmanager-plugin (Ubuntu Saucy):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers