clickmanager-plugin

Some errors are not being handled properly

Bug #1231146 reported by Diego Sarmentero
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
clickmanager-plugin
Fix Committed
Medium
Diego Sarmentero
clickmanager-plugin (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Some error situations like downloadNotCreated, network errors, etc are not being forwarded to the UI, so the user never knows why the program is not doing anything.

Related branches

lp:~diegosarmentero/clickmanager-plugin/sign-url
PS Jenkins bot (community): Approve (continuous-integration)
Alejandro J. Cura (community): Approve
dobey (community): Abstain
Diff: 839 lines (+246/-38)
27 files modified
debian/control (+3/-0)
src/application.cpp (+13/-4)
src/application.h (+10/-1)
src/clickmanager.cpp (+46/-11)
src/clickmanager.h (+19/-7)
src/clickmanager_plugin.cpp (+2/-0)
src/download/downloader.cpp (+6/-2)
src/download/downloader.h (+6/-2)
src/download_tracker.cpp (+4/-0)
src/download_tracker.h (+5/-1)
src/network/network.cpp (+3/-0)
src/network/network.h (+4/-0)
src/src.pro (+3/-2)
tests/fakedownloader.cpp (+11/-2)
tests/fakedownloader.h (+6/-2)
tests/fakenetwork.cpp (+4/-0)
tests/fakenetwork.h (+4/-0)
tests/fakeprocess.cpp (+4/-0)
tests/fakeprocess.h (+4/-0)
tests/fakessoservice.cpp (+16/-0)
tests/fakessoservice.h (+27/-0)
tests/test_main.cpp (+2/-0)
tests/testapplication.cpp (+4/-0)
tests/testapplication.h (+4/-0)
tests/testclickmanager.cpp (+23/-0)
tests/testclickmanager.h (+6/-0)
tests/tests.pro (+7/-4)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:clickmanager-plugin at revision 12, scheduled for release in clickmanager-plugin, milestone Unknown

Changed in clickmanager-plugin:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package clickmanager-plugin - 0.1+13.10.20130930.1-0ubuntu1

---------------
clickmanager-plugin (0.1+13.10.20130930.1-0ubuntu1) saucy; urgency=low

  [ Diego Sarmentero ]
  * Use a single instance of debVersion for comparison. (LP: #1231389)
  * Support signed url. - Improve error handling. (LP: #1231144,
    #1231146)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 12
 -- Ubuntu daily release <email address hidden> Mon, 30 Sep 2013 14:28:20 +0000

Changed in clickmanager-plugin (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.