review tools message when using 'type:os' with "confinement" in snap.yaml

[Oliver Grawert]

uploading a snapcraft built os snap to the store the selftest complains about os snaps not being allowed to have "confinement:" set. snapcraft should not forcefully add that option to the snap.yaml when "type: os" is set.

[Sergio Schvezov (sergiusens)]

 kyrofa just make sure to bring up the conflicts about type: core, gadget and kernel and if confinement makes sense; also think about core coming from say another distro (think about the built-on tag we discussed in Heildelberg) and think about the fact that some cores might not implement all the confinement primitives (where in that case the core snap would be devmode I guess)

[Kyle Fazzari (kyrofa)]

I've discussed this with the snapd core team. They pointed out that any snap, regardless of its type, may include hooks. Hooks are confined just like apps, which means the `confinement` flag still makes sense to include in snaps of types other than `app`.

As a result, it sounds like the review tools need to change. I'm not sure this bug will make sense if I reassign it, so please log a new one against that project.

[Kyle Fazzari (kyrofa)]

Or Sergio can update it while I'm commenting :P .

[Jamie Strandboge (jdstrand)]

Fine to change the review tools but I'd like to understand what hooks are run for 'type: os' and why are they confined?

/me notes we currently allow 'confinement' with 'app' and 'kernel' and just added for 'gadget' based on Kyle's comment.

[Jamie Strandboge (jdstrand)]

I should also mention that currently the tools don't block when 'confinement' is used with 'type: os', but they do mention it shouldn't be used (based on your answer to my last question, I'll obviously adjust as necessary).

[Jamie Strandboge (jdstrand)]

With 0.45 the review tools no longer complain.