tools do not handled abbreviated toplevel slots and plugs syntax correctly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Click Reviewers tools (obsolete) |
Fix Released
|
Medium
|
Celso Providelo | ||
click-reviewers-tools (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Yakkety |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
This is already fixed in the store so the SRU is for users to not see this failure their local system.
[Test Case]
Attached is a test snap
$ snap-review ./snap-
./snap-
[Regression Potential]
Regression potential is extremely low since this is already on production in the Ubuntu Store for many weeks.
= Original description =
This should be valid, but the review tools flag as an error:
apps:
networkmanager:
command: command-
daemon: simple
slots:
- service
nmcli:
command: command-
plugs:
- nmcli
architectures:
- amd64
confinement: strict
description: ...
name: network-manager
plugs:
nmcli: network-manager
slots:
service: network-manager
summary: Network management framework
version: 1.2.2-1
With the above, the tools error with:
unknown interface 'service' lint-snap-v2_slots (service, service)
unknown interface 'nmcli' lint-snap-v2_plugs (nmcli, nmcli)
Related branches
- Jamie Strandboge (community): Approve
-
Diff: 122 lines (+48/-11)3 files modifiedclickreviews/sr_lint.py (+29/-11)
clickreviews/tests/test_sr_lint.py (+18/-0)
debian/changelog (+1/-0)
Changed in click-reviewers-tools: | |
status: | New → Triaged |
importance: | Undecided → Medium |
description: | updated |
Changed in click-reviewers-tools: | |
assignee: | nobody → Celso Providelo (cprov) |
Changed in click-reviewers-tools (Ubuntu Xenial): | |
status: | New → In Progress |
Fixed in r684.