Store reports "package contains external symlinks: usr/lib/x86_64-linux-gnu/ lint-snap-v2_external_symlinks"

Bug #1584346 reported by Anthony Wong on 2016-05-21
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Jamie Strandboge
click-reviewers-tools (Ubuntu)

Bug Description

This is already fixed in the store so the SRU is for users to not see this failure their local system.

[Test Case]
A test case was added for this, but a real world test is to grab shadowsock from and run the tool on it:

$ snap-review /tmp/K51DuljGLGTBCESdYGXcuVymEPeyLI2S_2.snap
/tmp/K51DuljGLGTBCESdYGXcuVymEPeyLI2S_2.snap: pass

[Regression Potential]
Regression potential is extremely low since this is already on production in the Ubuntu Store for many weeks.

= Original description =
I think this bug is an issue of the ubuntu store, if this is not the correct project to report to, please re-assign to the correct one.

When I upload my package to the store, it reports this failure:
package contains external symlinks: usr/lib/x86_64-linux-gnu/ lint-snap-v2_external_symlinks

But ubuntu-core has the necessary file:

$ ls -l /snap/ubuntu-core/current/lib/x86_64-linux-gnu/libmvec*
-rw-r--r-- 1 root root 166368 Apr 15 06:16 /snap/ubuntu-core/current/lib/x86_64-linux-gnu/
lrwxrwxrwx 1 root root 15 Apr 15 06:16 /snap/ubuntu-core/current/lib/x86_64-linux-gnu/ ->

This is in my snap:

$ ls -l /snap/shadowsocks/current/usr/lib/x86_64-linux-gnu/*
lrwxrwxrwx 1 root root 34 Apr 15 06:17 /snap/shadowsocks/current/usr/lib/x86_64-linux-gnu/ -> /lib/x86_64-linux-gnu/

/lib/x86_64-linux-gnu/ was not in a previous version of ubuntu-core, so I wonder if this failure is due to the check in ubuntu store is not up-to-date?

Jamie Strandboge (jdstrand) wrote :

Can you attach the snap or comment on whether or not this is a python snap (and therefore a dupe of 1582513)?

Jamie Strandboge (jdstrand) wrote :

Per serguisens, this is a snapcraft bug, but since is part of libc, the review tools should give it a pass. Since bug 1582513 is for snapcraft, I'll take this one for the review tools.

no longer affects: snappy
Changed in click-reviewers-tools:
status: New → Triaged
assignee: nobody → Jamie Strandboge (jdstrand)
importance: Undecided → High
Jamie Strandboge (jdstrand) wrote :

Fix committed in r666.

Changed in click-reviewers-tools:
status: Triaged → Fix Committed
Jamie Strandboge (jdstrand) wrote :

Requested a store sync.

Jamie Strandboge (jdstrand) wrote :

Fixed in upstream 0.44 and in 16.10.

Changed in click-reviewers-tools (Ubuntu Yakkety):
status: New → Fix Released
Changed in click-reviewers-tools:
status: Fix Committed → Fix Released
description: updated
Changed in click-reviewers-tools (Ubuntu Xenial):
status: New → In Progress

Hello Anthony, or anyone else affected,

Accepted click-reviewers-tools into xenial-proposed. The package will build now and be available at in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at . Thank you in advance!

Changed in click-reviewers-tools (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Jamie Strandboge (jdstrand) wrote :

The revision of shadowsocks no longer exists in the store, but later revisions do:

$ click-review ~/Downloads/r7Rvf6wSWVkh7kSALwpOiyvjXbflDbPp_19.snap
 - lint-snap-v2:unknown_field
 unknown entries in snap.yaml: 'grade'
/home/jamie/Downloads/r7Rvf6wSWVkh7kSALwpOiyvjXbflDbPp_19.snap: FAIL

Note, this failed due to the fact the snap is using the new 'grade' yaml that will be in a separate SRU.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package click-reviewers-tools - 0.44~16.04.1

click-reviewers-tools (0.44~16.04.1) xenial-proposed; urgency=medium

  [ Jamie Strandboge ]
  * data/apparmor-easyprof-ubuntu.json:
    - add pulseaudio interface
    - add bluetooth policy group for Touch for 15.04 and higher
    - add location-observe and location-control
    - move all core interfaces to 'common'
    - add gsettings interface
    - set home to auto-approve
    - add mpris interface
    - add camera interface
    - add optical-drive interface
    - add serial-port interface
    - add content interface
  * clickreviews/
    - don't fail on since it comes from libc6 too (LP: #1584346)
    - extend the regex to also match
    - update _verify_pkgname() and _verify_appname() to use the same regex as
      in snapd and various tests
    - update attributes to be slots or plugs side and cleanup code for
      specifying attributes
  * bin/click-review, clickreviews/ exit '1' if error with
    init_object or running checks
    - support 'environment' key in yaml (LP: #1583259)
    - support 'confinement' key in yaml
    - specifying mpris slot should not warn
    - adjust profile name length checks to use series 16 security label format
  * run_tests: exit non-zero with failures, errors or unexpectedSuccesses
    - 'puritine' is a known, but redflagged hook
    - skip external symlinks and md5sums checks for puritine (since we expect
      external symlinks and the hash checks fail on broken symlinks)
    - 'puritine' hook should not be used with 'apparmor'
  * clickreviews/ adjust for rename of store team
    (LP: #1608943)

  [ Celso Providelo ]
  * support for interface abbreviated syntax (LP: #1595184)

 -- Jamie Strandboge <email address hidden> Tue, 02 Aug 2016 08:43:31 -0500

Changed in click-reviewers-tools (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for click-reviewers-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers