.mo files don't seem to be allowed in packages of arch 'all'

Bug #1530894 reported by Daniel Holbach
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Fix Released
Undecided
Daniel Holbach

Bug Description

https://plus.google.com/u/0/+SzymonWaliczek/posts/P9Pupxb3hEv

<beuno> I guess .mo's are technically binaries
<popey> people re-submit their app as armhf or whatever to pass the tests, which seems flawed for qml based apps
<beuno> indeed
<dholbach> so the problem (I think is in _list_all_compiled_binaries()), python-magic seems to return 'application/octet-stream; charset=binary' for all .mo files

Related branches

Revision history for this message
costales (costales) wrote :

In the manifiest.json, change:
   "architecture": "all",
by:
    "architecture": ["armhf", "i386", "amd64"],

that worked for me. A hug

Revision history for this message
Simos Xenitellis  (simosx) wrote :

I suppose that either the locale subdirectory should be excluded from testing for binary files.
or the "all" architecture should only contain the .po files that are compiled into .mo during installation (more chances for things to break).

Revision history for this message
Olivier Tilloy (osomon) wrote :

Can this be assigned and fixed? I can’t publish an update to an app of mine because of that bug. The workaround suggested by Marcos doesn’t look acceptable to me.

Changed in click-reviewers-tools:
status: New → Confirmed
Changed in click-reviewers-tools:
assignee: nobody → Daniel Holbach (dholbach)
status: Confirmed → In Progress
Changed in click-reviewers-tools:
status: In Progress → Fix Committed
Revision history for this message
Olivier Tilloy (osomon) wrote :

Does the "Fix Committed" status mean that automatic review by the store will now work? If so, can I re-upload the same version that failed the check, or do I need to bump the version?

Revision history for this message
Daniel Holbach (dholbach) wrote :

Olivier. No, the bug status in this project is unrelated to when myapps pulls in a new version of it.

Martin: how often is this done?

Revision history for this message
Daniel Holbach (dholbach) wrote :

myapps should up to date now.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This was fixed in 0.36.

Changed in click-reviewers-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.