click-review return code doesn't distinguish Warnings from Errors

[Alan Pope 🍺🐧🐱 🦄]

Run click-review across a bunch of click packages.
Currently:-

Success (no warning or error) = return code 0
Warnings only = return code 1
Errors only = return code 1
Errors and Warnings = return code 1

There's no way to discern between a package which only has warnings, and one which has errors only or both.

Running click-review from a script should, in my opinion, return 0 for success, perhaps 1 for warning and 2 for error.

alan@deep-thought:/tmp$ click-review /tmp/tmp.W9pkBNdwh1/com.ubuntu.developer.jonobacon.sleepytime_0.4_unknown.click
Errors
------
 - desktop:Icon:sleepytime
 'animal-farm' specified as icon in .desktop file for app 'sleepytime', which is not available in the click package.
 http://askubuntu.com/questions/417369/what-does-desktop-icon-mean/417370
Warnings
--------
 - lint:framework
 'ubuntu-sdk-13.10' is deprecated. Please use a newer framework
 http://askubuntu.com/questions/460512/what-framework-should-i-use-in-my-manifest-file
/tmp/tmp.W9pkBNdwh1/com.ubuntu.developer.jonobacon.sleepytime_0.4_unknown.click: FAIL
alan@deep-thought:/tmp$ echo $?
1

alan@deep-thought:/tmp$ click-review /tmp/tmp.3qlyuYJE8s/com.ubuntu.developer.djain29.unit-converter_0.1.3_all.click
Warnings
--------
 - lint:framework
 'ubuntu-sdk-13.10' is deprecated. Please use a newer framework
 http://askubuntu.com/questions/460512/what-framework-should-i-use-in-my-manifest-file
/tmp/tmp.3qlyuYJE8s/com.ubuntu.developer.djain29.unit-converter_0.1.3_all.click: FAIL
alan@deep-thought:/tmp$ echo $?
1

alan@deep-thought:/tmp$ click-review /tmp/tmp.XiNQEOyM83/com.ubuntu.developer.fcole90.hexgl_1.2_all.click
Errors
------
 - lint:framework
 'ubuntu-sdk-14.10-dev2' is obsolete. Please use a newer framework
 http://askubuntu.com/questions/460512/what-framework-should-i-use-in-my-manifest-file
/tmp/tmp.XiNQEOyM83/com.ubuntu.developer.fcole90.hexgl_1.2_all.click: FAIL
alan@deep-thought:/tmp$ echo $?
1

[Jamie Strandboge (jdstrand)]

"Running click-review from a script should, in my opinion, return 0 for success, perhaps 1 for warning and 2 for error." I think this is fine. I think I prefer '1' for errors/warning and '2' for just warnings but I can't really articulate why.

[Jamie Strandboge (jdstrand)]

Because tracebacks and our existing fatal errors exit with '1', I'm going to:

0: pass
1: fatal error
2: scripts ran but have errors/warnings
3. scripts ran but have warnings

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Super! Thanks for fixing this!

[Jamie Strandboge (jdstrand)]

Fixed in 0.39