The OnlineAccounts "type"element in .service file is not mandatory
Bug #1477000 reported by
Alberto Mardegan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical Click Reviewers tools (obsolete) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The click reviewers tool currently emits an error if a .service file does not contain the "type" element. While this parameter is indeed a required one for .service files, the Online Accounts click hook already takes care of inserting it if it's missing from the developer-supplied file.
The reason is that in most cases developers don't need to care about this field (it's used only when an application is able to use multiple accounts from different providers), so it's better to avoid them any trouble by auto-filling it with a sane value.
Related branches
lp:~mardy/click-reviewers-tools/no-service-type-check
- Jamie Strandboge (community): Approve
-
Diff: 34 lines (+3/-3)2 files modifiedclickreviews/cr_online_accounts.py (+1/-1)
clickreviews/tests/test_cr_online_accounts.py (+2/-2)
Revision history for this message
| Jamie Strandboge (jdstrand) wrote | #1 |
| Changed in click-reviewers-tools: | |
| status: | New → Fix Released |
To post a comment you must log in.
This was fixed in 0.33