Click review rejects multi-arch clicks

[Nicholas Skaggs]

The click review tools reject the valid syntax for multi-arch clicks. Attached is an example click which fails review with

Errors
------
 - lint_control_architecture_match
 Architecture=multi does not match manifest architecture=['armhf', 'i386', 'amd64']
 - security_policy_groups_safe_clock (calendar)
 (MANUAL REVIEW) reserved policy group 'calendar': vetted applications only
Warnings
--------
 - lint_click_local_extensions
 found unofficial extensions: x-source, x-test
com.ubuntu.developer.nskaggs.clock_3.2.169.3_multi.click: FAIL

*****************************
I'm including the manifest inline for ease of reference as well:

{
    "name": "com.ubuntu.developer.nskaggs.clock",
    "description": "A sophisticated clock app for Ubuntu Touch",
    "framework": "ubuntu-sdk-14.10",
    "architecture": ["armhf", "i386", "amd64"],
    "title": "Clock",
    "icon": "[e-mail]",
    "hooks": {
        "clock": {
            "apparmor": "ubuntu-clock-app.json",
            "desktop": "share/applications/ubuntu-clock-app.desktop",
            "urls": "share/url-dispatcher/urls/com.ubuntu.clock_clock.url-dispatcher"
        }
    },
    "version": "3.2.169.3",
    "maintainer": "Nicholas Skaggs <email address hidden>",
    "x-test": {
        "autopilot": "ubuntu_clock_app"
    },
    "x-source": {
        "vcs-bzr": "lp:ubuntu-clock-app",
        "vcs-bzr-revno": "169"
    }
}

[Daniel Holbach (dholbach)]

Do I assume correctly that multi-arch files are supposed to be named <namespace>_<version>_multi.click and have architecture in the manifest be

1) != multi
2) a list of valid_architectures
3) have the list of arches not contain 'all'

?

[Nicholas Skaggs (nskaggs)]

Daniel. yes I would say you are correct.

[Daniel Holbach (dholbach)]

I pushed a branch which might serve as a basis. I know that additional tests would need to be added - maybe this is going to help though.

[Jamie Strandboge (jdstrand)]

I keep meaning to get to this, but it keeps getting pushed back. If someone wants to do an MP for a full implementation with test cases, then we can probably find someone to review it. Thanks and sorry for not being able to get to it.

[Daniel Holbach (dholbach)]

AFAICS the branch is just missing tests at this stage.

[Daniel Holbach (dholbach)]

With r356:

daniel@daydream:~$ click-review com.ubuntu.developer.nskaggs.clock_3.2.169.3_multi.click
Errors
------
 - security_policy_groups_safe_clock (calendar)
 (MANUAL REVIEW) reserved policy group 'calendar': vetted applications only
Warnings
--------
 - lint_click_local_extensions
 found unofficial extensions: x-source, x-test
com.ubuntu.developer.nskaggs.clock_3.2.169.3_multi.click: FAIL
daniel@daydream:~$