Tools don't check for broken icon path

Bug #1257429 reported by Alan Pope 🍺🐧🐱 🦄
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Undecided
Daniel Holbach

Bug Description

On numerous occasions now I've reviewed apps which have passed all tests, install onto the device just fine, but show no icon on the phone.

This can be due to:-

a) A developer script which created the click package, screwing up the .desktop file: "Icon=foo.png" -> "on=foo.png"
b) Absolute path being given in .desktop file: "Icon=/usr/share/icon/foo.png"
c) Incorrect filename given in .desktop file: "Icon=foo.png" where the package ships with "bar.png" and no "foo.png" at all.

Can we add a check for some/all of these scenarios, as it causes a needless cycle of re-submission, which is especially frustrating for developers who have no device, so get no test unless one of the reviewers is kind enough to install and check it on device.

Revision history for this message
Daniel Holbach (dholbach) wrote :

a) and b) should be resolved according to the code.

c) theoretically isn't hard to do (if you just want to know "is the icon file in the package?"). What's harder to support are two cases
 - is the icon for it in somewhere in /usr/share/icons/?
 - does the author specify 'rocknroll-app' instead of 'rocknroll-app.png', which AFAIK should be fine as well.

Revision history for this message
Daniel Holbach (dholbach) wrote :

xdg.IconTheme maybe?

Revision history for this message
Daniel Holbach (dholbach) wrote :

IconTheme.getIconPath()

<seb128> dholbach, seems like that should work, though we might have a bit more logic for looking into click directories
<seb128> dholbach, http://bazaar.launchpad.net/~click-hackers/click/trunk/view/head:/doc/file-format.rst#L131
<seb128> dholbach, so you need to check first in the click dir then use the xdg standard lookup

Revision history for this message
Daniel Holbach (dholbach) wrote :

Ok. So after some research and a chat with popey, we could do

1) download ubuntu-mobile-icons, humanity-icon-theme, hicolor-icon-theme and unpack locally, walk filesystem and check if icon is there (including click unpack dir)
2) force app developer to ship icon in their click package

We decided to go with 2).

Changed in click-reviewers-tools:
assignee: nobody → Daniel Holbach (dholbach)
status: New → Fix Committed
Changed in click-reviewers-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers