Application Dir should be added to XDG_DATA_DIRS

Bug #1250546 reported by Christian Dywan
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Click Apparmor
Low
Jamie Strandboge
Ubuntu Application Launcher
Fix Released
Medium
Ted Gould
click-apparmor (Ubuntu)
Low
Jamie Strandboge
upstart-app-launch (Ubuntu)
Undecided
Unassigned

Bug Description

The installation directory of the click app should be added to XDG_DATA_DIRS for translations so that they can find the translated files.

Related branches

description: updated
Revision history for this message
Chris Wayne (cwayne) wrote :

The XDG_DATA_HOME is also not set in initctl list-env. If i do for example initctl set-env XDG_DATA_HOME=/usr/share/click/preinstalled/com.ubuntu.calendar/current/
 and then launch the calendar app with upstart-app-launch, it is translated.

Revision history for this message
Ted Gould (ted) wrote :

The output of a command similar to this one (arch and app id need to change):

$ G_MESSAGES_DEBUG=all APP_ID=foo /usr/lib/*/upstart-app-launch/click-exec

Ted Gould (ted)
summary: - XDG_DATA_HOME not defined
+ Application Dir should be added to XDG_DATA_DIRS
Chris Wayne (cwayne)
Changed in upstart-app-launch:
status: New → Confirmed
Ted Gould (ted)
description: updated
Ted Gould (ted)
Changed in upstart-app-launch:
importance: Undecided → Medium
assignee: nobody → Ted Gould (ted)
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

XDG_DATA_HOME should *not* be set to the install directory. Per http://developer.ubuntu.com/publish/apps/security-policy-for-click-packages/: "XDG_DATA_HOME: set to $HOME/.local/share". This follows the XDG specification and is what upstart-app-launch and aa-exec-click do currently.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Seems like XDG_DATA_DIRS should also be set in aa-exec-click for non-Unity8 DEs.

Changed in click-apparmor:
status: New → Triaged
importance: Undecided → Medium
importance: Medium → Low
assignee: nobody → Jamie Strandboge (jdstrand)
Ted Gould (ted)
Changed in upstart-app-launch:
status: Confirmed → In Progress
Revision history for this message
Chris Wayne (cwayne) wrote :

I tested with this branch, and while it seems XDG_DATA_DIRS is being set, the app itself is still not translated

Revision history for this message
Chris Wayne (cwayne) wrote :

I just retested to be sure, and I must have either used a language that was missing translations or forgot to reboot after setting the language, as this now works (by setting language to spanish, rebooting, and then opening calendar)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:upstart-app-launch at revision 82, scheduled for release in upstart-app-launch, milestone Unknown

Changed in upstart-app-launch:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package upstart-app-launch - 0.2+14.04.20131119-0ubuntu1

---------------
upstart-app-launch (0.2+14.04.20131119-0ubuntu1) trusty; urgency=low

  [ Ted Gould ]
  * Unref the proxy after stopping an application.
  * Use shell escaping to ensure we can handle spaces. (LP: #1229354)
  * Set the XDG Data Dirs to include the application install directory.
    (LP: #1250546)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 82
 -- Ubuntu daily release <email address hidden> Tue, 19 Nov 2013 08:19:25 +0000

Changed in upstart-app-launch (Ubuntu):
status: New → Fix Released
Ted Gould (ted)
Changed in upstart-app-launch:
status: Fix Committed → Fix Released
Changed in click-apparmor:
status: Triaged → In Progress
Changed in click-apparmor (Ubuntu):
status: New → In Progress
assignee: nobody → Jamie Strandboge (jdstrand)
importance: Undecided → Low
Changed in click-apparmor:
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package click-apparmor - 0.1.13

---------------
click-apparmor (0.1.13) trusty; urgency=low

  * prepend the click install directory to XDG_DATA_DIRS (LP: #1250546)
  * aa-exec-click: adjust to update LD_LIBRARY_PATH and QML2_IMPORT_PATH
  * debian/control: make click-apparmor Architecture: any so we can obtain
    the gnu triplet
  * debian/rules: adjust aa-exec-click for gnu triplet
 -- Jamie Strandboge <email address hidden> Tue, 17 Dec 2013 10:18:55 -0600

Changed in click-apparmor (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers