Don't use exit status 0 when rejecting login as root

[Attila Fazekas]

$ ssh -i mykey root@10.1.0.2 ls
Warning: Permanently added '10.1.0.2' (RSA) to the list of known hosts.
Please login as 'cirros' user, not as root

$ echo $?
0

Since the command is not executed the exit status should be non 0.

/root/.ssh/authorized_keys:
command="echo Please login as \'cirros\' user, not as root; echo; sleep 10" this part should be changed to:
"echo Please login as \'cirros\' user, not as root; echo; sleep 10; exit 1"

[Attila Fazekas (afazekas)]

Adding cloud-init as affacted project, because it also behavaes in this way.

[Dan Watkins (oddbloke)]

Won't fix in cloud-init because we don't want to break backwards compatibility.

[Scott Moser (smoser)]

fixed in master at e6d30c4d8b5a0903d900e9a00f9bc185ab25626c

[Dr. Jens Harbott (j-harbott)]

This should be fixed in 0.4.0, please re-open if you still see an issue there. Exit code is 43.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/2534