Volume snapshots and connection don't remove deleted instances

[Gorka Eguileor]

In some cases deleted snapshots and connections are not removed form the
cached lists, so we end up with a non existent element in the
"snapshots" or "connections" list that should not be there.

The reason why this happens is because we are looking for specific
instances instead of searching by the ID of the resource, and we could
have different instances in the list than the one we are looking for.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/643018

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/643018
Committed: https://git.openstack.org/cgit/openstack/cinderlib/commit/?id=4219b903303968a0899587863b46726d5f8427a1
Submitter: Zuul
Branch: master

commit 4219b903303968a0899587863b46726d5f8427a1
Author: Gorka Eguileor <email address hidden>
Date: Tue Mar 12 14:36:50 2019 +0100

    Fix Volume snapshots and connections on deletion

    In some cases deleted snapshots and connections are not removed form the
    cached lists, so we end up with a non existent element in the
    "snapshots" or "connections" list that should not be there.

    The reason why this happens is because we are looking for specific
    instances instead of searching by the ID of the resource, and we could
    have different instances in the list than the one we are looking for.

    This patch ensure we are always looking for the elements to remove using
    the ID.

    Closes-Bug: #1819709
    Change-Id: Ieb14e63c3de2f74f5d239a5174aeda9ee5c8fca1