Activity log for bug #1923313

Date Who What changed Old value New value Message
2021-04-10 16:02:16 MarkMielke bug added bug
2021-04-10 16:05:04 MarkMielke description This is similar to 1775678 and a few others. The code in GlanceImaceService.download() specifies: with open(parsed_url.path, "r") as f: shutil.copyfileobj(f, data) This code only takes effect if "file" is specified for allowed_direct_url_schemes. This results in hard to debug character set errors during image download. Luckily, it seems that the image usually fails to download with an obscure error rather than becoming corrupt. This should have been caught with the move to Python 3. Python 3 requires "rb" when opening binary files. "r" opens in text mode. It may be that allowed_direct_url_scheme is not used by very many people. However, I still use it, and I have been holding onto a local patch ("r" => "rb") since Train which resolves the problem every time. Opening this issue to start the process of getting the fix posted. This is similar to 1775678 and a few others. The code in GlanceImageService.download() (cinder/image/glance.py) specifies: with open(parsed_url.path, "r") as f:     shutil.copyfileobj(f, data) This code only takes effect if "file" is specified for allowed_direct_url_schemes. This results in hard to debug character set errors during image download. Luckily, it seems that the image usually fails to download with an obscure error rather than becoming corrupt. This should have been caught with the move to Python 3. Python 3 requires "rb" when opening binary files. "r" opens in text mode. It may be that allowed_direct_url_scheme is not used by very many people. However, I still use it, and I have been holding onto a local patch ("r" => "rb") since Train which resolves the problem every time. Opening this issue to start the process of getting the fix posted.
2021-04-12 13:41:05 Eric Harney cinder: status New In Progress
2021-04-12 13:41:10 Eric Harney cinder: assignee Eric Harney (eharney)
2021-04-16 14:43:12 Brian Rosmaita nominated for series cinder/train
2021-04-16 14:43:12 Brian Rosmaita bug task added cinder/train
2021-04-16 14:43:12 Brian Rosmaita nominated for series cinder/ussuri
2021-04-16 14:43:12 Brian Rosmaita bug task added cinder/ussuri
2021-04-16 14:43:12 Brian Rosmaita nominated for series cinder/victoria
2021-04-16 14:43:12 Brian Rosmaita bug task added cinder/victoria
2021-04-16 14:43:12 Brian Rosmaita nominated for series cinder/wallaby
2021-04-16 14:43:12 Brian Rosmaita bug task added cinder/wallaby
2021-04-16 14:43:12 Brian Rosmaita nominated for series cinder/xena
2021-04-16 14:43:12 Brian Rosmaita bug task added cinder/xena
2021-04-16 14:43:30 Brian Rosmaita cinder/xena: milestone xena-1
2021-04-16 14:43:35 Brian Rosmaita cinder/wallaby: milestone 18.0.1
2021-04-16 14:44:10 Brian Rosmaita cinder/victoria: milestone 17.1.1
2021-04-16 14:45:16 Brian Rosmaita cinder/ussuri: milestone 16.3.1
2021-04-16 14:45:22 Brian Rosmaita cinder/train: milestone 15.5.1
2021-04-19 16:40:27 OpenStack Infra cinder/wallaby: status New In Progress
2021-04-28 18:58:26 OpenStack Infra cinder: status In Progress Fix Released
2021-05-05 01:18:28 OpenStack Infra cinder/wallaby: status In Progress Fix Committed
2021-05-26 14:30:35 OpenStack Infra cinder/ussuri: status New In Progress
2021-06-03 23:59:04 Sofia Enriquez cinder/xena: importance Undecided High
2021-06-03 23:59:41 Sofia Enriquez tags files glance python3
2021-06-25 02:31:50 OpenStack Infra cinder/ussuri: status In Progress Fix Committed