Change in method name in tempest/common broke cinder's internal tempest tests

Bug #1667448 reported by Yogesh
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Yogesh
Ocata
Fix Released
Undecided
Eric Harney

Bug Description

Below change has renamed "wait_for_volume_status" to "wait_for_volume_resource_status" due to which tempest tests under cinder/tests/tempest/api/volume are broken.

https://review.openstack.org/#/c/394588

Error -
 setUpClass (cinder.tests.tempest.api.volume.test_volume_unicode.CinderUnicodeTest)
 ----------------------------------------------------------------------------------

 Captured traceback:
 ~~~~~~~~~~~~~~~~~~~
     Traceback (most recent call last):
       File "tempest/test.py", line 273, in setUpClass
         six.reraise(etype, value, trace)
       File "tempest/test.py", line 266, in setUpClass
         cls.resource_setup()
       File "/opt/stack/new/cinder/cinder/tests/tempest/api/volume/test_volume_unicode.py", line 35, in resource_setup
         cls.volume = cls.create_volume_with_args(name=cls.volume_name)
       File "/opt/stack/new/cinder/cinder/tests/tempest/api/volume/test_volume_unicode.py", line 48, in create_volume_with_args
         waiters.wait_for_volume_status(cls.volumes_client,
     AttributeError: 'module' object has no attribute 'wait_for_volume_status'

Yogesh (ykshirsa)
Changed in cinder:
assignee: nobody → Yogesh (ykshirsa)
Yogesh (ykshirsa)
Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/437604

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/437604
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=beca6c147ce67f7d7c417070ae921106625a2354
Submitter: Jenkins
Branch: master

commit beca6c147ce67f7d7c417070ae921106625a2354
Author: yogesh <email address hidden>
Date: Thu Feb 23 14:50:18 2017 -0500

    Fix internal tempest tests

    Existing methods - wait_for_volume_status,
    wait_for_snapshot_status and wait_for_backup_status
    were combined into
    wait_for_volume_resource_status.

    This patch is intended to fix the issue occured
    due to above change.

    Change-Id: Iaf1fd19a3fdf50aec8aaddffdcbaf6d0466fbd35
    Closes-bug:1667448

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Eric Harney (eharney) wrote :

This is breaking Ceph RBD CI on stable/ocata.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/444370

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/ocata)

Reviewed: https://review.openstack.org/444370
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b05afc3fbae2c82f89c8f0bbda31c79169595fc6
Submitter: Jenkins
Branch: stable/ocata

commit b05afc3fbae2c82f89c8f0bbda31c79169595fc6
Author: yogesh <email address hidden>
Date: Thu Feb 23 14:50:18 2017 -0500

    Fix internal tempest tests

    Existing methods - wait_for_volume_status,
    wait_for_snapshot_status and wait_for_backup_status
    were combined into
    wait_for_volume_resource_status.

    This patch is intended to fix the issue occured
    due to above change.

    Change-Id: Iaf1fd19a3fdf50aec8aaddffdcbaf6d0466fbd35
    Closes-bug:1667448
    (cherry picked from commit beca6c147ce67f7d7c417070ae921106625a2354)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.1

This issue was fixed in the openstack/cinder 10.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 11.0.0.0b1

This issue was fixed in the openstack/cinder 11.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/460814

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (stable/newton)

Change abandoned by Brian Rosmaita (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/460814
Reason: See Eric's comment on https://review.openstack.org/#/c/417329/ for the proper way to fix this.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.