iSCSI rescan at disconnect_volume, can orphan volumes
Bug #1483326 reported by
Walt Boring
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Invalid
|
Undecided
|
Unassigned | ||
Kilo |
Fix Released
|
Undecided
|
Patrick East | ||
os-brick |
Fix Released
|
High
|
Walt Boring |
Bug Description
When running nova live migration, doing an SCSI rescan inside of disconnect_volume can bring back removed volumes.
During nova live migration,
for every volume attached to a VM, nova will first call os-brick to disconnect_volume.
Then nova will call Cinder to terminate_
The problem is, when you do a rescan prior to having the Cinder driver terminate the connection, a volume that was removed locally, will show back up, and then be left behind after the migration is complete.
We should not be calling rescan during disconnect_volume time.
Changed in os-brick: | |
importance: | Undecided → High |
Changed in os-brick: | |
status: | New → In Progress |
Changed in os-brick: | |
milestone: | none → 0.4.0 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/203265 /git.openstack. org/cgit/ openstack/ os-brick/ commit/ ?id=c0839fa5506 7e96bf577d16b7b 9d825ae7b52aba
Committed: https:/
Submitter: Jenkins
Branch: master
commit c0839fa55067e96 bf577d16b7b9d82 5ae7b52aba
Author: Walter A. Boring IV <email address hidden>
Date: Fri Jul 17 15:42:43 2015 -0700
Remove the iSCSI rescan during disconnect
Doing an iSCSI rescan at disconnect time is pretty
dangerous to do. iSCSI rescan doesn't make volumes
go away, it makes them show back up. So during Nova
live migration it will make local scsi volumes show
back up.
Nova live migration first loops over volumes and calls volume, then after that it loops over the volumes connection.
disconnect_
again and call's cinder to terminate_
If disconnect_volume does a rescan, then volumes there were
removed during previous calls will show back up, because cinder's
driver hasn't had a chance to terminate the connection yet
from the array.
Closes-Bug: #1483326 7b09abad9f956fa 5a3bb4ba54c
Change-Id: I8708db16a4b905