Grizzly create from src and create from snap broken if not bootable

Bug #1246004 reported by John Griffith
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Invalid
High
Unassigned
Grizzly
Fix Released
High
John Griffith

Bug Description

The create from source and create from snapshot calls in Grizzly are currently broken for volumes that don't have glance_image_metadata associated with them. A check was added in Change-Id: I859bb2550267c6a5142e85ec89f1c7ff885588ac
to fix an issue that resulted in clones and snapshots not propagating the bootable settings. This didn't take in to account non-bootable volumes and snapshots, so an unhandled exception would hit when checking for the glance_metadata in the DB causing the clone operation to fail.

This should be handled by taskflow in Havana, it's a Grizzly only bug at this time.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/54398

Alan Pevec (apevec)
Changed in cinder:
status: In Progress → Invalid
assignee: John Griffith (john-griffith) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/grizzly)

Reviewed: https://review.openstack.org/54398
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3a3bcbb9c077223399859bb6ff2e625710673624
Submitter: Jenkins
Branch: stable/grizzly

commit 3a3bcbb9c077223399859bb6ff2e625710673624
Author: John Griffith <email address hidden>
Date: Tue Oct 29 18:43:57 2013 +0000

    Handle GlanceMetadataNotFound Exceptions

    Change number I859bb2550267c6a5142e85ec89f1c7ff885588ac
    fixed a bug where we weren't copying the bootable properties
    of a volume or snapshot on create from snap or volume.

    This didn't however handle the case of non-bootable volumes/snaps.

    The result is that when the db call to get the image metadata raises
    a NotFound exception we don't handle it and crash, causing the create
    operation to fail.

    This adds a try/except block around the copy volume/snap
    glance_metadata get calls and ignores the exception.

    Change-Id: Ibad730e7886b082d34717cd01b4ba31941e7594a
    Closes-Bug: 1246004

Alan Pevec (apevec)
tags: removed: grizzly
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.