Infinidat driver should use pool's compression setting when creating volumes

Bug #2017815 reported by Alexander Deiter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Alexander Deiter

Bug Description

Description: Infinidat driver should use pool's compression setting as default when creating volumes

Request from our customers and product manager:

1. We noticed that when volumes are created by Infinidat Cinder driver, they are created with compression disabled. The behavior should be changed to default to inherit from storage pool - we should only send compression_enabled in the InfiniBox creation request if the ``infinidat_use_compression`` option is actually set.

2. We may also remove support for pre-v3.0 InfiniBox systems that do not support compression. These versions are end of life and no longer supported for a long time.

Steps to reproduce:
* Create a pool in Infinidat storage with enabled compression option
* Configure Infinidat iSCSI or FC block storage backend
* Do not specify the ``infinidat_use_compression`` configuration option for the backend
* Create a new volume on top of the configured backend

Expected results:
The new volume was successfully created and inherited the compression setting from the parent storage pool

Actual results:
The new volume was successfully created with disabled compression option

Changed in cinder:
assignee: nobody → Alexander Deiter (adeiter)
description: updated
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/881188

Changed in cinder:
status: New → In Progress
tags: added: drivers infinidat
Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/881188
Committed: https://opendev.org/openstack/cinder/commit/026dd9d34a3fa9bfc912cb350953aef64a6864a5
Submitter: "Zuul (22348)"
Branch: master

commit 026dd9d34a3fa9bfc912cb350953aef64a6864a5
Author: Alexander Deiter <email address hidden>
Date: Thu Apr 27 15:50:30 2023 +0000

    Fix Infinidat driver to inherit compression

    * Fixed Infinidat driver to inherit compression setting by default for
      all newly created volumes. Admin can set ``True`` or ``False`` for
      the ``infinidat_use_compression`` option in the driver section of
      cinder.conf to explicitly enable or disable compression setting for
      all newly created volumes. Or leave this option unset (commented out)
      for all created volumes to inherit their compression setting from
      their parent pool at creation time. The default value is unset.

    * Removed support for pre-v3.0 InfiniBox systems that do not support
      compression. These versions are end of life and no longer supported
      for a long time

    Closes-bug: #2017815
    Signed-off-by: Alexander Deiter <email address hidden>
    Change-Id: I6a33e4c85057bdf79530f9c9f24d867c49931310

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 24.0.0.0rc1

This issue was fixed in the openstack/cinder 24.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.