HPE 3PAR: Unable to use vlan iscsi ips

[Raghavendra Tilay]

What is issue:
---------------

Sample output of "showport" command from HPE 3par storage system:

CSSOS-SSA04 cli% showport -iscsi
N:S:P State IPAddr Netmask/PrefixLen Gateway TPGT MTU Rate iSNS_Addr iSNS_Port STGT VLAN
0:2:1 ready 192.168.68.203 255.255.192.0 0.0.0.0 21 1500 10Gbps 0.0.0.0 3205 21 Y
0:2:2 ready 192.168.68.228 255.255.192.0 0.0.0.0 22 1500 10Gbps 0.0.0.0 3205 22 Y

CSSOS-SSA04 cli% showport -iscsivlans
N:S:P VLAN IPAddr Netmask/PrefixLen Gateway MTU TPGT STGT iSNS_Addr iSNS_Port
0:2:1 - 192.168.68.203 255.255.192.0 0.0.0.0 1500 21 21 0.0.0.0 3205
0:2:1 100 192.168.100.1 255.255.192.0 0.0.0.0 1500 1024 21 0.0.0.0 3205
0:2:1 200 192.168.100.2 255.255.255.0 0.0.0.0 1500 1028 1028 0.0.0.0 3205
0:2:2 - 192.168.68.228 255.255.192.0 0.0.0.0 1500 22 22 0.0.0.0 3205
0:2:2 100 192.168.100.7 255.255.192.0 0.0.0.0 1500 1025 22 0.0.0.0 3205
0:2:2 200 192.168.100.8 255.255.255.0 0.0.0.0 1500 1030 1030 0.0.0.0 3205

In /etc/cinder/cinder.conf, if only the vlan ips are specified as:
hpe3par_iscsi_ips=192.168.100.1,192.168.100.2

Then from initialize_iscsi_ports(), it gives below error:
At least one valid iSCSI IP address must be set

Also, the operation "attach volume to instance" also fails i.e _initialize_connection_common().

Why is this observed:
----------------------

In the code hpe_3par_iscsi.py, only the trunk ips (192.168.68.203) are considered.
The vlan ips (192.168.100.1) are not checked.

How to resolve:
---------------

In functions initialize_iscsi_ports() and _initialize_connection_common(),
in addition to trunk ips (192.168.68.203), consider vlan ips (192.168.100.1) also.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/878684

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/878684
Committed: https://opendev.org/openstack/cinder/commit/4482ec892f00a724fb2b2a56607d0815fe0c17e0
Submitter: "Zuul (22348)"
Branch: master

commit 4482ec892f00a724fb2b2a56607d0815fe0c17e0
Author: raghavendrat <email address hidden>
Date: Mon Apr 3 05:26:41 2023 +0000

    HPE 3PAR: use vlan iscsi ips

    In the code hpe_3par_iscsi.py, only the trunk ips
    (192.168.68.203) are considered. If vlan ips (192.168.100.1)
    are specified, they aren't considered while forming list of
    iscsi ips.

    Sample output of "showport" command from HPE 3par storage system:

    CSSOS-SSA04 cli% showport -iscsivlans
    N:S:P VLAN IPAddr Netmask
    0:2:1 - 192.168.68.203 255.255.192.0
    0:2:1 100 192.168.100.1 255.255.192.0
    0:2:1 200 192.168.100.2 255.255.255.0

    Kindly refer launchpad bug for details.

    This patch adds support for using vlan iscsi ips.

    Closes-Bug: #2015034
    Change-Id: Idaea18411ae03c5a9696b2ab67e84087177fcc74

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 23.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: unmaintained/wallaby
Review: https://review.opendev.org/c/openstack/cinder/+/915801

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/cinder/+/919868

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/919868
Committed: https://opendev.org/openstack/cinder/commit/b30ed079fc4073d38f9b52a2f9ae497d4967413a
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit b30ed079fc4073d38f9b52a2f9ae497d4967413a
Author: raghavendrat <email address hidden>
Date: Mon Apr 3 05:26:41 2023 +0000

    HPE 3PAR: use vlan iscsi ips

    In the code hpe_3par_iscsi.py, only the trunk ips
    (192.168.68.203) are considered. If vlan ips (192.168.100.1)
    are specified, they aren't considered while forming list of
    iscsi ips.

    Sample output of "showport" command from HPE 3par storage system:

    CSSOS-SSA04 cli% showport -iscsivlans
    N:S:P VLAN IPAddr Netmask
    0:2:1 - 192.168.68.203 255.255.192.0
    0:2:1 100 192.168.100.1 255.255.192.0
    0:2:1 200 192.168.100.2 255.255.255.0

    Kindly refer launchpad bug for details.

    This patch adds support for using vlan iscsi ips.

    Closes-Bug: #2015034
    Change-Id: Idaea18411ae03c5a9696b2ab67e84087177fcc74
    (cherry picked from commit 4482ec892f00a724fb2b2a56607d0815fe0c17e0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 22.2.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: unmaintained/wallaby
Review: https://review.opendev.org/c/openstack/cinder/+/915801
Reason: unmaintained/wallaby branch of openstack/cinder transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.