Cinder

Wrong assertion methods in unit tests

Bug #1989280 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Takashi Natsume
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Takashi Natsume
OpenStack Shared File Systems Service (Manila) antelope-rc1
cinderlib
Fix Released
Low
Takashi Natsume
os-brick
Fix Released
Low
Takashi Natsume
os-win
Fix Released
Undecided
Takashi Natsume
oslo.db
Fix Released
Undecided
Takashi Natsume

Bug Description

There are some wrong assertion methods in the master.

e.g.
https://opendev.org/openstack/cinder/src/commit/c86c9576f7e87789c2e20e2e7e9f8b6c8b6ef21f/cinder/tests/unit/backup/drivers/test_backup_glusterfs.py#L86

        utils.get_root_helper.called_once()

Tags: tests
Takashi Natsume (natsume-takashi)
Changed in cinder:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/856971

Changed in cinder:
status: New → In Progress
Takashi Natsume (natsume-takashi)
Changed in os-win:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-win (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/os-win/+/857042

Changed in os-win:
status: New → In Progress
Takashi Natsume (natsume-takashi)
Changed in os-brick:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (master)

Reviewed: https://review.opendev.org/c/openstack/os-win/+/857042
Committed: https://opendev.org/openstack/os-win/commit/a4effc7e5446908da9efc2bfef9915cba216b84d
Submitter: "Zuul (22348)"
Branch: master

commit a4effc7e5446908da9efc2bfef9915cba216b84d
Author: Takashi Natsume <email address hidden>
Date: Mon Sep 12 20:01:09 2022 +0900

    Fix wrong assertion methods

    Replcae 'has_calls' with 'assert_has_calls' or
    remove 'has_calls'.

    Change-Id: I65f9a761af75d94052362056fe1c9ba152f6449e
    Closes-Bug: 1989280
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in os-win:
status: In Progress → Fix Released
Changed in os-brick:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/os-brick/+/857044

Takashi Natsume (natsume-takashi)
Changed in cinderlib:
assignee: nobody → Takashi Natsume (natsume-takashi)
OpenStack Infra (hudson-openstack)
Changed in cinderlib:
status: New → In Progress
Sofia Enriquez (lsofia-enriquez)
tags: added: test
Changed in cinder:
importance: Undecided → Low
Changed in cinderlib:
importance: Undecided → Low
Changed in os-brick:
importance: Undecided → Low
Takashi Natsume (natsume-takashi)
Changed in oslo.db:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.db (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/oslo.db/+/858264

Changed in oslo.db:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.db (master)

Reviewed: https://review.opendev.org/c/openstack/oslo.db/+/858264
Committed: https://opendev.org/openstack/oslo.db/commit/995a81d305e0e3819bb768666399b662d2bbc724
Submitter: "Zuul (22348)"
Branch: master

commit 995a81d305e0e3819bb768666399b662d2bbc724
Author: Takashi Natsume <email address hidden>
Date: Mon Sep 19 18:07:39 2022 +0900

    Fix misuse of assert_has_calls

    The 'assert_has_calls' is a method, not a variable.

    Change-Id: I6aea978b8fc9adf4a062c149c84d6562f5adec04
    Closes-Bug: 1989280
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in oslo.db:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.db 12.2.0

This issue was fixed in the openstack/oslo.db 12.2.0 release.

Revision history for this message
Sofia Enriquez (lsofia-enriquez) wrote :

Hi, the fix was merged in oslo, should we mark this bug as fixed?
Thanks,
Sofia

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-win 5.8.0

This issue was fixed in the openstack/os-win 5.8.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinderlib (master)

Reviewed: https://review.opendev.org/c/openstack/cinderlib/+/855823
Committed: https://opendev.org/openstack/cinderlib/commit/e4da0146a5081dce5ff045aa5f28713af7fb64a0
Submitter: "Zuul (22348)"
Branch: master

commit e4da0146a5081dce5ff045aa5f28713af7fb64a0
Author: Takashi Natsume <email address hidden>
Date: Mon Sep 5 00:04:01 2022 +0900

    Fix wrong assertion methods in unit tests

    Replace 'called_once_with' with 'assert_called_once_with'.
    Replace 'asssert_called_once_with' with 'assert_called_once_with'.

    Change-Id: Ie5f07de8c09cf4764223278acf1724c20c8d7694
    Partial-Bug: 1989280
    Signed-off-by: Takashi Natsume <email address hidden>

Sofia Enriquez (lsofia-enriquez)
tags: added: tests
removed: test
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.opendev.org/c/openstack/os-brick/+/857044
Committed: https://opendev.org/openstack/os-brick/commit/e7b1426e31ecd4a5e177036248df1cf8733e1e14
Submitter: "Zuul (22348)"
Branch: master

commit e7b1426e31ecd4a5e177036248df1cf8733e1e14
Author: Takashi Natsume <email address hidden>
Date: Mon Sep 12 20:54:06 2022 +0900

    Fix wrong assertion methods

    Replace 'called_once_with' with 'assert_called_once_with'.

    Change-Id: I18b55da0d1f142818e7ea14f6eebcc0f0f0cd23f
    Closes-Bug: 1989280
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in os-brick:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 6.2.0

This issue was fixed in the openstack/os-brick 6.2.0 release.

Takashi Natsume (natsume-takashi)
Changed in cinderlib:
status: In Progress → Fix Released
Takashi Natsume (natsume-takashi)
Changed in manila:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/874347

Changed in manila:
status: New → In Progress
Goutham Pacha Ravi (gouthamr)
Changed in manila:
importance: Undecided → Low
milestone: none → antelope-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/874347
Committed: https://opendev.org/openstack/manila/commit/adcec06b7bda2159639e7f9b36526fccf1716287
Submitter: "Zuul (22348)"
Branch: master

commit adcec06b7bda2159639e7f9b36526fccf1716287
Author: Takashi Natsume <email address hidden>
Date: Sat Feb 18 21:23:19 2023 +0900

    Fix wrong assertion methods

    Change-Id: I06d2d434a4e9449e4cae4f1acd2b6d304a4658e3
    Closes-Bug: 1989280
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 16.0.0.0rc1

This issue was fixed in the openstack/manila 16.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.opendev.org/c/openstack/cinder/+/856971
Committed: https://opendev.org/openstack/cinder/commit/dfef52f3a6e6ba6fde0e985621673064c8c86356
Submitter: "Zuul (22348)"
Branch: master

commit dfef52f3a6e6ba6fde0e985621673064c8c86356
Author: Takashi Natsume <email address hidden>
Date: Sun Sep 11 19:54:08 2022 +0900

    Fix wrong assertion methods

    Change-Id: I0e1ce867c76fcf4fb5784550c1f1f051498176a4
    Closes-Bug: 1989280
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 23.0.0.0rc1

This issue was fixed in the openstack/cinder 23.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.