Infinidat Cinder driver consistency groups feature is broken

[Alexander Deiter]

Infinidat Cinder driver consistency groups feature is broken.

The Infinidat Cinder driver ignores the group id property when creating a new volume and does not add new volume to group.

Steps to reproduce:
* Install an OpenStack environment: Queens or newer version
* Configure Infinidat iSCSI or FC backend
* Create a consistency group
* Create a volume as a member of the group
* Try to create a consistency group snapshot

Expected results:
Success

Actual results:
Aug 08 17:47:30 devstack-aio-iscsi-master cinder-volume[679114]: ERROR cinder.volume.drivers.infinidat [None req-5eab71c2-55da-49e5-a758-3fe5abf00945 tempest-
ConsistencyGroupsV2Test-1126116403 None] Caught exception from infinisdk: API Command Failed
Request: POST https://box:443/api/rest/cgs?approved=true
Request Timestamp: 2022-08-08T17:47:30.438135+00:00
Response Timestamp: 2022-08-08T17:47:30.522746+00:00
Data: '{"snap_prefix": null, "parent_id": 77430, "snap_suffix": "_1659980850334", "name": "openstack-group-snap-9bbf4cd5-fed0-49d3-ac50-3f80f016a93c", "lock_expires_at": null}'
Status: 409
Code: CG_SNAP_WITH_NO_MEMBERS
Message: Cannot take a snapshot of an empty consistency group
Cookies: JSESSIONID=95895541EB37C8D79EDE05BF010410CC: infinisdk.core.exceptions.APICommandFailed: API Command Failed
Request: POST https://box:443/api/rest/cgs?approved=true
Request Timestamp: 2022-08-08T17:47:30.438135+00:00
Response Timestamp: 2022-08-08T17:47:30.522746+00:00
Data: '{"snap_prefix": null, "parent_id": 77430, "snap_suffix": "_1659980850334", "name": "openstack-group-snap-9bbf4cd5-fed0-49d3-ac50-3f80f016a93c", "lock_expires_at": null}'
Status: 409
Code: CG_SNAP_WITH_NO_MEMBERS
Message: Cannot take a snapshot of an empty consistency group
Cookies: JSESSIONID=95895541EB37C8D79EDE05BF010410CC

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/infinisdk/core/api/api.py", line 660, in assert_success
    self.response.raise_for_status()
  File "/usr/local/lib/python3.8/dist-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 409 Client Error: Conflict for url: https://box:443/api/rest/cgs?approved=true

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/852369

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/852369
Committed: https://opendev.org/openstack/cinder/commit/d0d63dc7d8055b4719a6fd4c16f29d1d157be9d3
Submitter: "Zuul (22348)"
Branch: master

commit d0d63dc7d8055b4719a6fd4c16f29d1d157be9d3
Author: Alexander Deiter <email address hidden>
Date: Tue Aug 9 11:23:22 2022 +0000

    Fix Infinidat driver consistency groups feature

    Fixed Infinidat driver to take into account the group
    identifier property when creating a new volume and
    add the volume to the consistency group.

    Closes-bug: #1984000
    Change-Id: Ie5b19330c4d2b7018bde615494b58b9f89945e02
    Signed-off-by: Alexander Deiter <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 22.0.0.0rc1 release candidate.